StrangeBrew icon indicating copy to clipboard operation
StrangeBrew copied to clipboard

New ingredients from QBrew recipe saved incorrectly

Open DougEdey opened this issue 12 years ago • 6 comments

Converted from SourceForge issue 1518402, submitted by dlevey

I don't think that anything changed since the last working invocation (really!). However, now when starting up and explicitly calling the 1.5 JRE I get:

[don@daedalus Strangebrew]$ j15 -jar strangebrew_fat.jar DB Path: /home/don/Strangebrew/src/ca/strangebrew/data Exception in thread "main" java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at com.simontuffs.onejar.Boot.run(Boot.java:247) at com.simontuffs.onejar.Boot.main(Boot.java:105) Caused by: java.lang.InternalError: Failed to invoke main method at ca.strangebrew.ui.swing.dialogs.SplashWindow.invokeMain(SplashWindow.java:205) at ca.strangebrew.ui.swing.dialogs.Splash.main(Splash.java:26) ... 6 more Caused by: java.lang.ArrayIndexOutOfBoundsException: 6 at ca.strangebrew.Database.readHops(Database.java:252) at ca.strangebrew.Database.readDB(Database.java:94) at ca.strangebrew.ui.swing.StrangeSwing.(StrangeSwing.java:419) at ca.strangebrew.ui.swing.dialogs.SplashWindow.invokeMain(SplashWindow.java:202) ... 7 more [don@daedalus Strangebrew]$ j15 -version java version "1.5.0_07" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_07-b03) Java HotSpot(TM) Client VM (build 1.5.0_07-b03, mixed mode, sharing) [don@daedalus Strangebrew]$

DougEdey avatar Jun 09 '12 23:06 DougEdey

Submitted by dlevey

Logged In: YES user_id=908023

Additional notes: Same platform (Fedora Core 5 smp) The splash screen comes up and stays on the screen; will terminate only when the user control-c to interrupt - not seemingly using CPU after the crash.

DougEdey avatar Jun 09 '12 23:06 DougEdey

Submitted by andrew_avis

Logged In: YES user_id=1135612

Looks like the hops DB might be corrupted? If you look in src/ca/strangebrew/data/ what hops* files do you see? (Should be hops.csv) -- there might be a backup file too, if the app found a new hop and added it to your db. If this is the case, try replacing the hops.csv with the backup. If it's the case, could you send me the new (bad) hops.csv file?

DougEdey avatar Jun 09 '12 23:06 DougEdey

Submitted by dlevey

Logged In: YES user_id=908023

It looks like it may have been yeast, or both hops and yeast. Here they are.

DougEdey avatar Jun 09 '12 23:06 DougEdey

Submitted by andrew_avis

Logged In: YES user_id=1135612

Looks like new ingredients picked up from a QBrew recipe get saved incorrectly in the database, which causes severe problems on the next startup.

DougEdey avatar Jun 09 '12 23:06 DougEdey

Submitted by dlevey

Logged In: YES user_id=908023

Interesting... I opened one of the recipes included with the download bundle (don't remember which one, unfortunately).

DougEdey avatar Jun 09 '12 23:06 DougEdey

Submitted by andrew_avis

Logged In: YES user_id=1135612

I'm guessing it was housebest.qbrew -- it contains a hop called "homegrown cascade", which was on the first corrupted line. The problem was that hop objects (and yeast - anything based on the ingredient object) don't initialize their description, and a null string gets written as a line break (or something) by CSVWriter.

Fixed in CVS, will be fixed in the next RC release.

DougEdey avatar Jun 09 '12 23:06 DougEdey