Survival-Games icon indicating copy to clipboard operation
Survival-Games copied to clipboard

SurvivalGames Arenas not ending properly

Open ghost opened this issue 11 years ago • 38 comments

I run a massive Server and i am using the survivalgames plugin. When my arenas end, When you click to sign it says 'Cant join arena' the if you look at the sign it says 'FINISHING' and it only fixes if i restart the server but happens again when it ends. I have redownloaded the plugin and tried a different version and this is still occurring. It does come with a crash when this happens. Please help me out! Here is the crash http://pastebin.com/YSrD9jRV Thanks A Lot

ghost avatar Nov 03 '13 03:11 ghost

I will take a look. There are a lot of bugs like this though.

Pocketkid2 avatar Nov 04 '13 17:11 Pocketkid2

Is there any more error messages?

Pocketkid2 avatar Nov 04 '13 17:11 Pocketkid2

https://github.com/Double0negative/Survival-Games/pull/96 This is what I think will fix the problem

Pocketkid2 avatar Nov 04 '13 23:11 Pocketkid2

So it's something to do with spectating that is causing it to happen?

ghost avatar Nov 04 '13 23:11 ghost

And there are no other crashes that come with it sorry

ghost avatar Nov 04 '13 23:11 ghost

Well, if you read the stack trace, it says it's getting a NullPointerException in the code for removing spectators. I took a look at the code, and I did some fixing up that might fix it. This whole plugin is full of crappy code. I'm thinking about making my own stable version

Pocketkid2 avatar Nov 04 '13 23:11 Pocketkid2

I am with you though I have noticed this problem since I started using it practically :)

Pocketkid2 avatar Nov 04 '13 23:11 Pocketkid2

Yeah it is crap code. That would be awesome for you to make your own. I would even pay! Do just to be clear, what should I do to fix this bug so my arenas stay working ?

ghost avatar Nov 04 '13 23:11 ghost

Well, if the author approves my pull request, then maybe the bug is fixed. I will do some extensive testing, and coding of my own. I can get back to you if I get a build that works.

Pocketkid2 avatar Nov 05 '13 00:11 Pocketkid2

Oh please do! Thanks so much for that :) if you would like add my skype chrisbadaoui2000

ghost avatar Nov 05 '13 00:11 ghost

Ok. I really enjoy coding Bukkit plugins. I mostly do it just for the fun of making something, and fixing things that nobody has time to fix. it's sorta my hobby :)

Pocketkid2 avatar Nov 05 '13 00:11 Pocketkid2

This is the first build of my in-progress re-creating of SurvivalGames. Check it out, and report any errors. We can set up skype, but later. :) http://www.mediafire.com/download/q72wd6k8dpc5ddc/SurvivalGamesReloaded.jar

Pocketkid2 avatar Nov 05 '13 00:11 Pocketkid2

BTW It is expected to have LOTS of errors.

Pocketkid2 avatar Nov 05 '13 00:11 Pocketkid2

Just fixed some more initial transfer bugs. Here ya go: http://www.mediafire.com/?hh0ysji30dqja7z

Pocketkid2 avatar Nov 05 '13 00:11 Pocketkid2

Do I set it up like the original plugin?

ghost avatar Nov 05 '13 01:11 ghost

Sure. Beware it should have bugs, so you might want to just make sure your safely save and restart your server

Pocketkid2 avatar Nov 05 '13 01:11 Pocketkid2

I can't acces skype right now, but I will contact you via skype ASIC

Pocketkid2 avatar Nov 05 '13 01:11 Pocketkid2

No problem! Once you add me on skype I will report all the bugs to you :)

ghost avatar Nov 05 '13 01:11 ghost

Ok... But you can start reporting any first bugs right now if you would. (I would like that)

Pocketkid2 avatar Nov 05 '13 01:11 Pocketkid2

No problem. Did you fix the bug where you can join arenas though ?

ghost avatar Nov 05 '13 01:11 ghost

Also is the plugin compatible with 1.5.2? As my server is 1.5.2

ghost avatar Nov 05 '13 01:11 ghost

With the SG plugin you made, i wanted to ask are you able to fix deathmatch up? So it counts from 10-0 then gets teleported to the middle? And do you recon its hard to add statistics to the side? Like when you join the arena, it tells you how many players have died, alive, and what arena number? Thanks so much keep up the awesome work! BTW was this plugin meant to fix the 'cant join arena' problem?

ghost avatar Nov 05 '13 07:11 ghost

Here is my first bug, when i try to join the arena it says ' joining arena 1' then i get tped to where i set the spawn points but i can move around and the signs dont say that i joined the arena. Here is also the error http://pastebin.com/J42ZKbzv

ghost avatar Nov 05 '13 07:11 ghost

Alright. This is just a test, to see if I can get the code to work in a new repo controlled by me, It should work with older builds, though I do compile for 1.6.4 R2.0. After I fix all the initial bugs I should be able to finish implementing all the things the previous author forgot (sponsor, deathmatch, etc...). For now I will focus on the main bugs.

Pocketkid2 avatar Nov 05 '13 20:11 Pocketkid2

LAWL You're error was a syntax error on my part :)

Pocketkid2 avatar Nov 05 '13 20:11 Pocketkid2

Alright for now try this: http://www.mediafire.com/?7zdtufe5bqnd26d

Pocketkid2 avatar Nov 05 '13 20:11 Pocketkid2

Thanks

ghost avatar Nov 05 '13 20:11 ghost

I removed spectating and now my arenas are fine ! :D Does your build allow spectators and has that bug fixed?

ghost avatar Nov 05 '13 20:11 ghost

What do you mean you 'removed spectating'? I might have fixed the bug, why don't you check for me?

Pocketkid2 avatar Nov 05 '13 23:11 Pocketkid2

Sounds to me like your bug is in the code, that when a match ends, the plugin runs through its protocols, either missing or skipping the step that would remove the spectators from the arena once it stops, leaving it stuck in the "FINISHING" mode. I suggest you remove the entire spectating feature of this plugin or fix this bug, I gave up on this plugin when @Double0negative stopped authoring/merging solid pull requests. @Double0negative if you care about this plugin and its future, hand it off to a more capable programmer or get to work merging these solid pull requests.

PatchGuru avatar Nov 10 '13 19:11 PatchGuru