sipml5 icon indicating copy to clipboard operation
sipml5 copied to clipboard

Call Hold/Resume Fails

Open sbpkhostings opened this issue 3 years ago • 2 comments

I am using the API version 2.1.4

When the call is placed on hold and then resumed, the previous media stream is no longer continued. The receiver does not get any audio.

sbpkhostings avatar Feb 04 '22 10:02 sbpkhostings

We fixed this by making the resume asynchronous and using "replaceTrack" instead of "addTrack" which adds another Sender, instead of updating tracks in the existing sender. We think this is a change from the WebRTC API from when this was originally developed. Our commit is a giant bundled commit so a pull request isn't gonna just work easily, but the code is here on line 450 of this commit: https://github.com/L1kMakes/sipml5-ng/commit/6fd731d57e79fb2e07e2fc84f216a1d4fd63ef21#diff-0ca66776a62cfb4af660b32adc09131b21a58c29741db80e237ee710eb2ce5e6

surfrock66 avatar Feb 16 '22 20:02 surfrock66

I solved this problem by transferring the user to herself when he click to resume button.

YasinKara avatar Feb 24 '23 09:02 YasinKara