LeaguePyBot
LeaguePyBot copied to clipboard
Update dependency aiohttp to v3.9.4 [SECURITY]
This PR contains the following updates:
Package | Update | Change |
---|---|---|
aiohttp | minor | ==3.7.4.post0 -> ==3.9.4 |
CVE-2023-47641 / GHSA-xx9p-xxvh-7g8j / PYSEC-2023-247
More information
Details
aiohttp is an asynchronous HTTP client/server framework for asyncio and Python. Affected versions of aiohttp have a security vulnerability regarding the inconsistent interpretation of the http protocol. HTTP/1.1 is a persistent protocol, if both Content-Length(CL) and Transfer-Encoding(TE) header values are present it can lead to incorrect interpretation of two entities that parse the HTTP and we can poison other sockets with this incorrect interpretation. A possible Proof-of-Concept (POC) would be a configuration with a reverse proxy(frontend) that accepts both CL and TE headers and aiohttp as backend. As aiohttp parses anything with chunked, we can pass a chunked123 as TE, the frontend entity will ignore this header and will parse Content-Length. The impact of this vulnerability is that it is possible to bypass any proxy rule, poisoning sockets to other users like passing Authentication Headers, also if it is present an Open Redirect an attacker could combine it to redirect random users to another website and log the request. This vulnerability has been addressed in release 3.8.0 of aiohttp. Users are advised to upgrade. There are no known workarounds for this vulnerability.
Severity
- CVSS Score: 6.5 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-xx9p-xxvh-7g8j
- https://github.com/aio-libs/aiohttp/commit/f016f0680e4ace6742b03a70cb0382ce86abe371
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
Aiohttp has inconsistent interpretation of Content-Length
vs. Transfer-Encoding
differing in C and Python fallbacks
CVE-2023-47641 / GHSA-xx9p-xxvh-7g8j / PYSEC-2023-247
More information
Details
Impact
Aiohttp has a security vulnerability regarding the inconsistent interpretation of the http protocol. As we know that HTTP/1.1 is persistent, if we have both Content-Length(CL) and Transfer-Encoding(TE) it can lead to incorrect interpretation of two entities that parse the HTTP and we can poison other sockets with this incorrect interpretation.
A possible Proof-of-Concept (POC) would be a configuration with a reverse proxy(frontend) that accepts both CL and TE headers and aiohttp as backend. As aiohttp parses anything with chunked, we can pass a chunked123 as TE, the frontend entity will ignore this header and will parse Content-Length. I can give a Dockerfile with the configuration if you want.
The impact of this vulnerability is that it is possible to bypass any proxy rule, poisoning sockets to other users like passing Authentication Headers, also if it is present an Open Redirect (just like CVE-2021-21330) we can combine it to redirect random users to our website and log the request.
References
- https://github.com/aio-libs/aiohttp/commit/f016f0680e4ace6742b03a70cb0382ce86abe371
Severity
- CVSS Score: 3.4 / 10 (Low)
- Vector String:
CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:C/C:L/I:N/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-xx9p-xxvh-7g8j
- https://nvd.nist.gov/vuln/detail/CVE-2023-47641
- https://github.com/aio-libs/aiohttp/commit/f016f0680e4ace6742b03a70cb0382ce86abe371
- https://github.com/aio-libs/aiohttp
- https://github.com/aio-libs/aiohttp/releases/tag/v3.8.0
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
aiohttp.web.Application vulnerable to HTTP request smuggling via llhttp HTTP request parser
CVE-2023-37276 / GHSA-45c4-8wx5-qw6w / PYSEC-2023-120
More information
Details
Impact
aiohttp v3.8.4 and earlier are bundled with llhttp v6.0.6 which is vulnerable to CVE-2023-30589. The vulnerable code is used by aiohttp for its HTTP request parser when available which is the default case when installing from a wheel.
This vulnerability only affects users of aiohttp as an HTTP server (ie aiohttp.Application
), you are not affected by this vulnerability if you are using aiohttp as an HTTP client library (ie aiohttp.ClientSession
).
Reproducer
from aiohttp import web
async def example(request: web.Request):
headers = dict(request.headers)
body = await request.content.read()
return web.Response(text=f"headers: {headers} body: {body}")
app = web.Application()
app.add_routes([web.post('/', example)])
web.run_app(app)
Sending a crafted HTTP request will cause the server to misinterpret one of the HTTP header values leading to HTTP request smuggling.
$ printf "POST / HTTP/1.1\r\nHost: localhost:8080\r\nX-Abc: \rxTransfer-Encoding: chunked\r\n\r\n1\r\nA\r\n0\r\n\r\n" \
| nc localhost 8080
Expected output:
headers: {'Host': 'localhost:8080', 'X-Abc': '\rxTransfer-Encoding: chunked'} body: b''
Actual output (note that 'Transfer-Encoding: chunked' is an HTTP header now and body is treated differently)
headers: {'Host': 'localhost:8080', 'X-Abc': '', 'Transfer-Encoding': 'chunked'} body: b'A'
Patches
Upgrade to the latest version of aiohttp to resolve this vulnerability. It has been fixed in v3.8.5: pip install aiohttp >= 3.8.5
Workarounds
If you aren't able to upgrade you can reinstall aiohttp using AIOHTTP_NO_EXTENSIONS=1
as an environment variable to disable the llhttp HTTP request parser implementation. The pure Python implementation isn't vulnerable to request smuggling:
$ python -m pip uninstall --yes aiohttp
$ AIOHTTP_NO_EXTENSIONS=1 python -m pip install --no-binary=aiohttp --no-cache aiohttp
References
- https://nvd.nist.gov/vuln/detail/CVE-2023-30589
- https://hackerone.com/reports/2001873
Severity
Unknown
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-45c4-8wx5-qw6w
- https://nvd.nist.gov/vuln/detail/CVE-2023-37276
- https://github.com/aio-libs/aiohttp
- https://hackerone.com/reports/2001873
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
aiohttp.web.Application vulnerable to HTTP request smuggling via llhttp HTTP request parser
CVE-2023-37276 / GHSA-45c4-8wx5-qw6w / PYSEC-2023-120
More information
Details
Impact
aiohttp v3.8.4 and earlier are bundled with llhttp v6.0.6 which is vulnerable to CVE-2023-30589. The vulnerable code is used by aiohttp for its HTTP request parser when available which is the default case when installing from a wheel.
This vulnerability only affects users of aiohttp as an HTTP server (ie aiohttp.Application
), you are not affected by this vulnerability if you are using aiohttp as an HTTP client library (ie aiohttp.ClientSession
).
Reproducer
from aiohttp import web
async def example(request: web.Request):
headers = dict(request.headers)
body = await request.content.read()
return web.Response(text=f"headers: {headers} body: {body}")
app = web.Application()
app.add_routes([web.post('/', example)])
web.run_app(app)
Sending a crafted HTTP request will cause the server to misinterpret one of the HTTP header values leading to HTTP request smuggling.
$ printf "POST / HTTP/1.1\r\nHost: localhost:8080\r\nX-Abc: \rxTransfer-Encoding: chunked\r\n\r\n1\r\nA\r\n0\r\n\r\n" \
| nc localhost 8080
Expected output:
headers: {'Host': 'localhost:8080', 'X-Abc': '\rxTransfer-Encoding: chunked'} body: b''
Actual output (note that 'Transfer-Encoding: chunked' is an HTTP header now and body is treated differently)
headers: {'Host': 'localhost:8080', 'X-Abc': '', 'Transfer-Encoding': 'chunked'} body: b'A'
Patches
Upgrade to the latest version of aiohttp to resolve this vulnerability. It has been fixed in v3.8.5: pip install aiohttp >= 3.8.5
Workarounds
If you aren't able to upgrade you can reinstall aiohttp using AIOHTTP_NO_EXTENSIONS=1
as an environment variable to disable the llhttp HTTP request parser implementation. The pure Python implementation isn't vulnerable to request smuggling:
$ python -m pip uninstall --yes aiohttp
$ AIOHTTP_NO_EXTENSIONS=1 python -m pip install --no-binary=aiohttp --no-cache aiohttp
References
- https://nvd.nist.gov/vuln/detail/CVE-2023-30589
- https://hackerone.com/reports/2001873
Severity
- CVSS Score: 5.3 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-45c4-8wx5-qw6w
- https://nvd.nist.gov/vuln/detail/CVE-2023-37276
- https://github.com/aio-libs/aiohttp/commit/9337fb3f2ab2b5f38d7e98a194bde6f7e3d16c40
- https://github.com/aio-libs/aiohttp/commit/9c13a52c21c23dfdb49ed89418d28a5b116d0681
- https://hackerone.com/reports/2001873
- https://github.com/aio-libs/aiohttp
- https://github.com/aio-libs/aiohttp/blob/v3.8.4/.gitmodules
- https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2023-120.yaml
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2023-47627 / GHSA-gfw2-4jvh-wgfg / PYSEC-2023-246
More information
Details
aiohttp is an asynchronous HTTP client/server framework for asyncio and Python. The HTTP parser in AIOHTTP has numerous problems with header parsing, which could lead to request smuggling. This parser is only used when AIOHTTP_NO_EXTENSIONS is enabled (or not using a prebuilt wheel). These bugs have been addressed in commit d5c12ba89
which has been included in release version 3.8.6. Users are advised to upgrade. There are no known workarounds for these issues.
Severity
- CVSS Score: 7.5 / 10 (High)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-gfw2-4jvh-wgfg
- https://github.com/aio-libs/aiohttp/commit/d5c12ba890557a575c313bb3017910d7616fce3d
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
aiohttp has vulnerable dependency that is vulnerable to request smuggling
More information
Details
Summary
llhttp 8.1.1 is vulnerable to two request smuggling vulnerabilities. Details have not been disclosed yet, so refer to llhttp for future information. The issue is resolved by using llhttp 9+ (which is included in aiohttp 3.8.6+).
Severity
Moderate
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-pjjw-qhg8-p2p9
- https://github.com/aio-libs/aiohttp/commit/996de2629ef6b4c2934a7c04dfd49d0950d4c43b
- https://github.com/aio-libs/aiohttp/commit/bcc416e533796d04fb8124ef1e7686b1f338767a
- https://github.com/aio-libs/aiohttp
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
AIOHTTP has problems in HTTP parser (the python one, not llhttp)
CVE-2023-47627 / GHSA-gfw2-4jvh-wgfg / PYSEC-2023-246
More information
Details
Summary
The HTTP parser in AIOHTTP has numerous problems with header parsing, which could lead to request smuggling.
This parser is only used when AIOHTTP_NO_EXTENSIONS
is enabled (or not using a prebuilt wheel).
Details
Bug 1: Bad parsing of Content-Length
values
Description
RFC 9110 says this:
Content-Length = 1*DIGIT
AIOHTTP does not enforce this rule, presumably because of an incorrect usage of the builtin int
constructor. Because the int
constructor accepts +
and -
prefixes, and digit-separating underscores, using int
to parse CL values leads AIOHTTP to significant misinterpretation.
Examples
GET / HTTP/1.1\r\n
Content-Length: -0\r\n
\r\n
X
GET / HTTP/1.1\r\n
Content-Length: +0_1\r\n
\r\n
X
Suggested action
Verify that a Content-Length
value consists only of ASCII digits before parsing, as the standard requires.
Bug 2: Improper handling of NUL, CR, and LF in header values
Description
RFC 9110 says this:
Field values containing CR, LF, or NUL characters are invalid and dangerous, due to the varying ways that implementations might parse and interpret those characters; a recipient of CR, LF, or NUL within a field value MUST either reject the message or replace each of those characters with SP before further processing or forwarding of that message.
AIOHTTP's HTTP parser does not enforce this rule, and will happily process header values containing these three forbidden characters without replacing them with SP.
Examples
GET / HTTP/1.1\r\n
Header: v\x00alue\r\n
\r\n
GET / HTTP/1.1\r\n
Header: v\ralue\r\n
\r\n
GET / HTTP/1.1\r\n
Header: v\nalue\r\n
\r\n
Suggested action
Reject all messages with NUL, CR, or LF in a header value. The translation to space thing, while technically allowed, does not seem like a good idea to me.
Bug 3: Improper stripping of whitespace before colon in HTTP headers
Description
RFC 9112 says this:
No whitespace is allowed between the field name and colon. In the past, differences in the handling of such whitespace have led to security vulnerabilities in request routing and response handling. A server MUST reject, with a response status code of 400 (Bad Request), any received request message that contains whitespace between a header field name and colon.
AIOHTTP does not enforce this rule, and will simply strip any whitespace before the colon in an HTTP header.
Example
GET / HTTP/1.1\r\n
Content-Length : 1\r\n
\r\n
X
Suggested action
Reject all messages with whitespace before a colon in a header field, as the standard requires.
PoC
Example requests are embedded in the previous section. To reproduce these bugs, start an AIOHTTP server without llhttp (i.e. AIOHTTP_NO_EXTENSIONS=1
) and send the requests given in the previous section. (e.g. by printf
ing into nc
)
Impact
Each of these bugs can be used for request smuggling.
Severity
- CVSS Score: 5.3 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-gfw2-4jvh-wgfg
- https://nvd.nist.gov/vuln/detail/CVE-2023-47627
- https://github.com/aio-libs/aiohttp/commit/d5c12ba890557a575c313bb3017910d7616fce3d
- https://github.com/aio-libs/aiohttp
- https://github.com/aio-libs/aiohttp/releases/tag/v3.8.6
- https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2023-246.yaml
- https://lists.fedoraproject.org/archives/list/[email protected]/message/FUSJVQ7OQ55RWL4XAX2F5EZ73N4ZSH6U
- https://lists.fedoraproject.org/archives/list/[email protected]/message/VDKQ6HM3KNDU4OQI476ZWT4O7DMSIT35
- https://lists.fedoraproject.org/archives/list/[email protected]/message/WQYQL6WV535EEKSNH7KRARLLMOW5WXDM
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2023-49082 / GHSA-qvrw-v9rv-5rjx / PYSEC-2023-251
More information
Details
aiohttp is an asynchronous HTTP client/server framework for asyncio and Python. Improper validation makes it possible for an attacker to modify the HTTP request (e.g. insert a new header) or even create a new HTTP request if the attacker controls the HTTP method. The vulnerability occurs only if the attacker can control the HTTP method (GET, POST etc.) of the request. If the attacker can control the HTTP version of the request it will be able to modify the request (request smuggling). This issue has been patched in version 3.9.0.
Severity
- CVSS Score: 5.3 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-qvrw-v9rv-5rjx
- https://gist.github.com/jnovikov/7f411ae9fe6a9a7804cf162a3bdbb44b
- https://github.com/aio-libs/aiohttp/pull/7806/files
- https://github.com/aio-libs/aiohttp/commit/e4ae01c2077d2cfa116aa82e4ff6866857f7c466
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
CVE-2023-49081 / GHSA-q3qx-c6g2-7pw2 / PYSEC-2023-250
More information
Details
aiohttp is an asynchronous HTTP client/server framework for asyncio and Python. Improper validation made it possible for an attacker to modify the HTTP request (e.g. to insert a new header) or create a new HTTP request if the attacker controls the HTTP version. The vulnerability only occurs if the attacker can control the HTTP version of the request. This issue has been patched in version 3.9.0.
Severity
- CVSS Score: 5.3 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-q3qx-c6g2-7pw2
- https://gist.github.com/jnovikov/184afb593d9c2114d77f508e0ccd508e
- https://github.com/aio-libs/aiohttp/pull/7835/files
- https://github.com/aio-libs/aiohttp/commit/1e86b777e61cf4eefc7d92fa57fa19dcc676013b
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
aiohttp's ClientSession is vulnerable to CRLF injection via method
CVE-2023-49082 / GHSA-qvrw-v9rv-5rjx / PYSEC-2023-251
More information
Details
Summary
Improper validation makes it possible for an attacker to modify the HTTP request (e.g. insert a new header) or even create a new HTTP request if the attacker controls the HTTP method.
Details
The vulnerability occurs only if the attacker can control the HTTP method (GET, POST etc.) of the request.
Previous releases performed no validation on the provided value. If an attacker controls the HTTP method it will be used as is and can lead to HTTP request smuggling.
PoC
A minimal example can be found here: https://gist.github.com/jnovikov/7f411ae9fe6a9a7804cf162a3bdbb44b
Impact
If the attacker can control the HTTP version of the request it will be able to modify the request (request smuggling).
Workaround
If unable to upgrade and using user-provided values for the request method, perform manual validation of the user value (e.g. by restricting it to a few known values like GET, POST etc.).
Patch: https://github.com/aio-libs/aiohttp/pull/7806/files
Severity
- CVSS Score: 5.3 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-qvrw-v9rv-5rjx
- https://nvd.nist.gov/vuln/detail/CVE-2023-49082
- https://github.com/aio-libs/aiohttp/pull/7806/files
- https://github.com/aio-libs/aiohttp/commit/e4ae01c2077d2cfa116aa82e4ff6866857f7c466
- https://gist.github.com/jnovikov/7f411ae9fe6a9a7804cf162a3bdbb44b
- https://github.com/aio-libs/aiohttp
- https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2023-251.yaml
- https://lists.fedoraproject.org/archives/list/[email protected]/message/TY5SI6NK5243DEEDQUFKQKW5GQNKQUMA
- https://lists.fedoraproject.org/archives/list/[email protected]/message/WSYWMP64ZFCTC3VO6RY6EC6VSSMV6I3A
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
aiohttp's ClientSession is vulnerable to CRLF injection via version
CVE-2023-49081 / GHSA-q3qx-c6g2-7pw2 / PYSEC-2023-250
More information
Details
Summary
Improper validation make it possible for an attacker to modify the HTTP request (e.g. to insert a new header) or even create a new HTTP request if the attacker controls the HTTP version.
Details
The vulnerability only occurs if the attacker can control the HTTP version of the request (including its type).
For example if an unvalidated JSON value is used as a version and the attacker is then able to pass an array as the version
parameter.
Furthermore, the vulnerability only occurs when the Connection
header is passed to the headers
parameter.
At this point, the library will use the parsed value to create the request. If a list is passed, then it bypasses validation and it is possible to perform CRLF injection.
PoC
The POC below shows an example of providing an unvalidated array as a version: https://gist.github.com/jnovikov/184afb593d9c2114d77f508e0ccd508e
Impact
CRLF injection leading to Request Smuggling.
Workaround
If these specific conditions are met and you are unable to upgrade, then validate the user input to the version
parameter to ensure it is a str
.
Patch: https://github.com/aio-libs/aiohttp/pull/7835/files
Severity
- CVSS Score: 7.2 / 10 (High)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:L/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-q3qx-c6g2-7pw2
- https://nvd.nist.gov/vuln/detail/CVE-2023-49081
- https://github.com/aio-libs/aiohttp/pull/7835/files
- https://github.com/aio-libs/aiohttp/commit/1e86b777e61cf4eefc7d92fa57fa19dcc676013b
- https://gist.github.com/jnovikov/184afb593d9c2114d77f508e0ccd508e
- https://github.com/aio-libs/aiohttp
- https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2023-250.yaml
- https://lists.fedoraproject.org/archives/list/[email protected]/message/TY5SI6NK5243DEEDQUFKQKW5GQNKQUMA
- https://lists.fedoraproject.org/archives/list/[email protected]/message/WSYWMP64ZFCTC3VO6RY6EC6VSSMV6I3A
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2024-23334 / GHSA-5h86-8mv2-jq9f / PYSEC-2024-24
More information
Details
aiohttp is an asynchronous HTTP client/server framework for asyncio and Python. When using aiohttp as a web server and configuring static routes, it is necessary to specify the root path for static files. Additionally, the option 'follow_symlinks' can be used to determine whether to follow symbolic links outside the static root directory. When 'follow_symlinks' is set to True, there is no validation to check if reading a file is within the root directory. This can lead to directory traversal vulnerabilities, resulting in unauthorized access to arbitrary files on the system, even when symlinks are not present. Disabling follow_symlinks and using a reverse proxy are encouraged mitigations. Version 3.9.2 fixes this issue.
Severity
- CVSS Score: 7.5 / 10 (High)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-5h86-8mv2-jq9f
- https://github.com/aio-libs/aiohttp/pull/8079
- https://github.com/aio-libs/aiohttp/commit/1c335944d6a8b1298baf179b7c0b3069f10c514b
- https://lists.fedoraproject.org/archives/list/[email protected]/message/XXWVZIVAYWEBHNRIILZVB3R3SDQNNAA7/
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
CVE-2024-23829 / GHSA-8qpw-xqxj-h4r2 / PYSEC-2024-26
More information
Details
aiohttp is an asynchronous HTTP client/server framework for asyncio and Python. Security-sensitive parts of the Python HTTP parser retained minor differences in allowable character sets, that must trigger error handling to robustly match frame boundaries of proxies in order to protect against injection of additional requests. Additionally, validation could trigger exceptions that were not handled consistently with processing of other malformed input. Being more lenient than internet standards require could, depending on deployment environment, assist in request smuggling. The unhandled exception could cause excessive resource consumption on the application server and/or its logging facilities. This vulnerability exists due to an incomplete fix for CVE-2023-47627. Version 3.9.2 fixes this vulnerability.
Severity
- CVSS Score: 6.5 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:L
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-8qpw-xqxj-h4r2
- https://github.com/aio-libs/aiohttp/pull/8074
- https://github.com/aio-libs/aiohttp/commit/33ccdfb0a12690af5bb49bda2319ec0907fa7827
- https://lists.fedoraproject.org/archives/list/[email protected]/message/XXWVZIVAYWEBHNRIILZVB3R3SDQNNAA7/
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
aiohttp is vulnerable to directory traversal
CVE-2024-23334 / GHSA-5h86-8mv2-jq9f / PYSEC-2024-24
More information
Details
Summary
Improperly configuring static resource resolution in aiohttp when used as a web server can result in the unauthorized reading of arbitrary files on the system.
Details
When using aiohttp as a web server and configuring static routes, it is necessary to specify the root path for static files. Additionally, the option 'follow_symlinks' can be used to determine whether to follow symbolic links outside the static root directory. When 'follow_symlinks' is set to True, there is no validation to check if a given file path is within the root directory.This can lead to directory traversal vulnerabilities, resulting in unauthorized access to arbitrary files on the system, even when symlinks are not present.
i.e. An application is only vulnerable with setup code like:
app.router.add_routes([
web.static("/static", "static/", follow_symlinks=True), # Remove follow_symlinks to avoid the vulnerability
])
Impact
This is a directory traversal vulnerability with CWE ID 22. When using aiohttp as a web server and enabling static resource resolution with follow_symlinks
set to True, it can lead to this vulnerability. This vulnerability has been present since the introduction of the follow_symlinks
parameter.
Workaround
Even if upgrading to a patched version of aiohttp, we recommend following these steps regardless.
If using follow_symlinks=True
outside of a restricted local development environment, disable the option immediately. This option is NOT needed to follow symlinks which point to a location within the static root directory, it is only intended to allow a symlink to break out of the static directory. Even with this CVE fixed, there is still a substantial risk of misconfiguration when using this option on a server that accepts requests from remote users.
Additionally, aiohttp has always recommended using a reverse proxy server (such as nginx) to handle static resources and not to use these static resources in aiohttp for production environments. Doing so also protects against this vulnerability, and is why we expect the number of affected users to be very low.
Patch: https://github.com/aio-libs/aiohttp/pull/8079/files
Severity
- CVSS Score: 5.9 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-5h86-8mv2-jq9f
- https://nvd.nist.gov/vuln/detail/CVE-2024-23334
- https://github.com/aio-libs/aiohttp/pull/8079
- https://github.com/aio-libs/aiohttp/pull/8079/files
- https://github.com/aio-libs/aiohttp/commit/1c335944d6a8b1298baf179b7c0b3069f10c514b
- https://github.com/aio-libs/aiohttp
- https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2024-24.yaml
- https://lists.fedoraproject.org/archives/list/[email protected]/message/ICUOCFGTB25WUT336BZ4UNYLSZOUVKBD
- https://lists.fedoraproject.org/archives/list/[email protected]/message/XXWVZIVAYWEBHNRIILZVB3R3SDQNNAA7
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
aiohttp's HTTP parser (the python one, not llhttp) still overly lenient about separators
CVE-2024-23829 / GHSA-8qpw-xqxj-h4r2 / PYSEC-2024-26
More information
Details
Summary
Security-sensitive parts of the Python HTTP parser retained minor differences in allowable character sets, that must trigger error handling to robustly match frame boundaries of proxies in order to protect against injection of additional requests. Additionally, validation could trigger exceptions that were not handled consistently with processing of other malformed input.
Details
These problems are rooted in pattern matching protocol elements, previously improved by PR #β3235 and GHSA-gfw2-4jvh-wgfg:
-
The expression
HTTP/(\d).(\d)
lacked another backslash to clarify that the separator should be a literal dot, not just any Unicode code point (result:HTTP/(\d)\.(\d)
). -
The HTTP version was permitting Unicode digits, where only ASCII digits are standards-compliant.
-
Distinct regular expressions for validating HTTP Method and Header field names were used - though both should (at least) apply the common restrictions of rfc9110
token
.
PoC
GET / HTTP/1ΓΆ1
GET / HTTP/1.π
GET/: HTTP/1.1
Content-Encoding?: chunked
Impact
Primarily concerns running an aiohttp server without llhttp:
- behind a proxy: Being more lenient than internet standards require could, depending on deployment environment, assist in request smuggling.
- directly accessible or exposed behind proxies relaying malformed input: the unhandled exception could cause excessive resource consumption on the application server and/or its logging facilities.
Patch: https://github.com/aio-libs/aiohttp/pull/8074/files
Severity
- CVSS Score: 6.5 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:L
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-8qpw-xqxj-h4r2
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-gfw2-4jvh-wgfg
- https://nvd.nist.gov/vuln/detail/CVE-2024-23829
- https://github.com/aio-libs/aiohttp/pull/3235
- https://github.com/aio-libs/aiohttp/pull/8074
- https://github.com/aio-libs/aiohttp/pull/8074/files
- https://github.com/aio-libs/aiohttp/commit/33ccdfb0a12690af5bb49bda2319ec0907fa7827
- https://github.com/aio-libs/aiohttp
- https://github.com/pypa/advisory-database/tree/main/vulns/aiohttp/PYSEC-2024-26.yaml
- https://lists.fedoraproject.org/archives/list/[email protected]/message/ICUOCFGTB25WUT336BZ4UNYLSZOUVKBD
- https://lists.fedoraproject.org/archives/list/[email protected]/message/XXWVZIVAYWEBHNRIILZVB3R3SDQNNAA7
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
aiohttp vulnerable to Denial of Service when trying to parse malformed POST requests
CVE-2024-30251 / GHSA-5m98-qgg9-wh84
More information
Details
Summary
An attacker can send a specially crafted POST (multipart/form-data) request. When the aiohttp server processes it, the server will enter an infinite loop and be unable to process any further requests.
Impact
An attacker can stop the application from serving requests after sending a single request.
For anyone needing to patch older versions of aiohttp, the minimum diff needed to resolve the issue is (located in _read_chunk_from_length()
):
diff --git a/aiohttp/multipart.py b/aiohttp/multipart.py
index 227be605c..71fc2654a 100644
--- a/aiohttp/multipart.py
+++ b/aiohttp/multipart.py
@​@​ -338,6 +338,8 @​@​ class BodyPartReader:
assert self._length is not None, "Content-Length required for chunked read"
chunk_size = min(size, self._length - self._read_bytes)
chunk = await self._content.read(chunk_size)
+ if self._content.at_eof():
+ self._at_eof = True
return chunk
async def _read_chunk_from_stream(self, size: int) -> bytes:
This does however introduce some very minor issues with handling form data. So, if possible, it would be recommended to also backport the changes in: https://github.com/aio-libs/aiohttp/commit/cebe526b9c34dc3a3da9140409db63014bc4cf19 https://github.com/aio-libs/aiohttp/commit/7eecdff163ccf029fbb1ddc9de4169d4aaeb6597 https://github.com/aio-libs/aiohttp/commit/f21c6f2ca512a026ce7f0f6c6311f62d6a638866
Severity
- CVSS Score: 7.5 / 10 (High)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-5m98-qgg9-wh84
- https://nvd.nist.gov/vuln/detail/CVE-2024-30251
- https://github.com/aio-libs/aiohttp/commit/7eecdff163ccf029fbb1ddc9de4169d4aaeb6597
- https://github.com/aio-libs/aiohttp/commit/cebe526b9c34dc3a3da9140409db63014bc4cf19
- https://github.com/aio-libs/aiohttp/commit/f21c6f2ca512a026ce7f0f6c6311f62d6a638866
- https://github.com/aio-libs/aiohttp
- http://www.openwall.com/lists/oss-security/2024/05/02/4
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
aiohttp Cross-site Scripting vulnerability on index pages for static file handling
CVE-2024-27306 / GHSA-7gpw-8wmc-pm8g
More information
Details
Summary
A XSS vulnerability exists on index pages for static file handling.
Details
When using web.static(..., show_index=True)
, the resulting index pages do not escape file names.
If users can upload files with arbitrary filenames to the static directory, the server is vulnerable to XSS attacks.
Workaround
We have always recommended using a reverse proxy server (e.g. nginx) for serving static files. Users following the recommendation are unaffected.
Other users can disable show_index
if unable to upgrade.
Patch: https://github.com/aio-libs/aiohttp/pull/8319/files
Severity
- CVSS Score: 6.1 / 10 (Medium)
- Vector String:
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N
References
- https://github.com/aio-libs/aiohttp/security/advisories/GHSA-7gpw-8wmc-pm8g
- https://nvd.nist.gov/vuln/detail/CVE-2024-27306
- https://github.com/aio-libs/aiohttp/pull/8319
- https://github.com/aio-libs/aiohttp/pull/8319/files
- https://github.com/aio-libs/aiohttp/commit/28335525d1eac015a7e7584137678cbb6ff19397
- https://github.com/aio-libs/aiohttp
- https://lists.fedoraproject.org/archives/list/[email protected]/message/2EXRGTN2WG7VZLUZ7WOXU5GQJKCPPHKP
- https://lists.fedoraproject.org/archives/list/[email protected]/message/NWEI6NIHZ3G7DURDZVMRK7ZEFC2BTD3U
- https://lists.fedoraproject.org/archives/list/[email protected]/message/ZIVBMPEY7WWOFMC3CWXFBRQPFECV4SW3
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
aio-libs/aiohttp (aiohttp)
v3.9.4
==================
Bug fixes
-
The asynchronous internals now set the underlying causes when assigning exceptions to the future objects -- by :user:
webknjaz
.Related issues and pull requests on GitHub: :issue:
8089
. -
Treated values of
Accept-Encoding
header as case-insensitive when checking for gzip files -- by :user:steverep
.Related issues and pull requests on GitHub: :issue:
8104
. -
Improved the DNS resolution performance on cache hit -- by :user:
bdraco
.This is achieved by avoiding an :mod:
asyncio
task creation in this case.Related issues and pull requests on GitHub: :issue:
8163
. -
Changed the type annotations to allow
dict
on :meth:aiohttp.MultipartWriter.append
, :meth:aiohttp.MultipartWriter.append_json
and :meth:aiohttp.MultipartWriter.append_form
-- by :user:cakemanny
Related issues and pull requests on GitHub: :issue:
7741
. -
Ensure websocket transport is closed when client does not close it -- by :user:
bdraco
.The transport could remain open if the client did not close it. This change ensures the transport is closed when the client does not close it.
Related issues and pull requests on GitHub: :issue:
8200
. -
Leave websocket transport open if receive times out or is cancelled -- by :user:
bdraco
.This restores the behavior prior to the change in #β7978.
Related issues and pull requests on GitHub: :issue:
8251
. -
Fixed content not being read when an upgrade request was not supported with the pure Python implementation. -- by :user:
bdraco
.Related issues and pull requests on GitHub: :issue:
8252
. -
Fixed a race condition with incoming connections during server shutdown -- by :user:
Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8271
. -
Fixed
multipart/form-data
compliance with :rfc:7578
-- by :user:Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8280
. -
Fixed blocking I/O in the event loop while processing files in a POST request -- by :user:
bdraco
.Related issues and pull requests on GitHub: :issue:
8283
. -
Escaped filenames in static view -- by :user:
bdraco
.Related issues and pull requests on GitHub: :issue:
8317
. -
Fixed the pure python parser to mark a connection as closing when a response has no length -- by :user:
Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8320
.
Features
-
Upgraded llhttp to 9.2.1, and started rejecting obsolete line folding in Python parser to match -- by :user:
Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8146
, :issue:8292
.
Deprecations (removal in next major release)
-
Deprecated
content_transfer_encoding
parameter in :py:meth:FormData.add_field() <aiohttp.FormData.add_field>
-- by :user:Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8280
.
Improved documentation
-
Added a note about canceling tasks to avoid delaying server shutdown -- by :user:
Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8267
.
Contributor-facing changes
-
The pull request template is now asking the contributors to answer a question about the long-term maintenance challenges they envision as a result of merging their patches -- by :user:
webknjaz
.Related issues and pull requests on GitHub: :issue:
8099
. -
Updated CI and documentation to use NPM clean install and upgrade node to version 18 -- by :user:
steverep
.Related issues and pull requests on GitHub: :issue:
8116
. -
A pytest fixture
hello_txt
was introduced to aid static file serving tests in :file:test_web_sendfile_functional.py
. It dynamically provisionshello.txt
file variants shared across the tests in the module.-- by :user:
steverep
Related issues and pull requests on GitHub: :issue:
8136
.
Packaging updates and notes for downstreams
-
Added an
internal
pytest marker for tests which should be skipped by packagers (use-m 'not internal'
to disable them) -- by :user:Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8299
.
v3.9.3
==================
Bug fixes
-
Fixed backwards compatibility breakage (in 3.9.2) of
ssl
parameter when set outside ofClientSession
(e.g. directly inTCPConnector
) -- by :user:Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
8097
, :issue:8098
.
Miscellaneous internal changes
-
Improved test suite handling of paths and temp files to consistently use pathlib and pytest fixtures.
Related issues and pull requests on GitHub: :issue:
3957
.
v3.9.2
==================
Bug fixes
-
Fixed server-side websocket connection leak.
Related issues and pull requests on GitHub: :issue:
7978
. -
Fixed
web.FileResponse
doing blocking I/O in the event loop.Related issues and pull requests on GitHub: :issue:
8012
. -
Fixed double compress when compression enabled and compressed file exists in server file responses.
Related issues and pull requests on GitHub: :issue:
8014
. -
Added runtime type check for
ClientSession
timeout
parameter.Related issues and pull requests on GitHub: :issue:
8021
. -
Fixed an unhandled exception in the Python HTTP parser on header lines starting with a colon -- by :user:
pajod
.Invalid request lines with anything but a dot between the HTTP major and minor version are now rejected. Invalid header field names containing question mark or slash are now rejected. Such requests are incompatible with :rfc:
9110#section-5.6.2
and are not known to be of any legitimate use.Related issues and pull requests on GitHub: :issue:
8074
. -
Improved validation of paths for static resources requests to the server -- by :user:
bdraco
.Related issues and pull requests on GitHub: :issue:
8079
.
Features
-
Added support for passing :py:data:
True
tossl
parameter inClientSession
while deprecating :py:data:None
-- by :user:xiangyan99
.Related issues and pull requests on GitHub: :issue:
7698
.
Breaking changes
-
Fixed an unhandled exception in the Python HTTP parser on header lines starting with a colon -- by :user:
pajod
.Invalid request lines with anything but a dot between the HTTP major and minor version are now rejected. Invalid header field names containing question mark or slash are now rejected. Such requests are incompatible with :rfc:
9110#section-5.6.2
and are not known to be of any legitimate use.Related issues and pull requests on GitHub: :issue:
8074
.
Improved documentation
-
Fixed examples of
fallback_charset_resolver
function in the :doc:client_advanced
document. -- by :user:henry0312
.Related issues and pull requests on GitHub: :issue:
7995
. -
The Sphinx setup was updated to avoid showing the empty changelog draft section in the tagged release documentation builds on Read The Docs -- by :user:
webknjaz
.Related issues and pull requests on GitHub: :issue:
8067
.
Packaging updates and notes for downstreams
-
The changelog categorization was made clearer. The contributors can now mark their fragment files more accurately -- by :user:
webknjaz
.The new category tags are:
* ``bugfix`` * ``feature`` * ``deprecation`` * ``breaking`` (previously, ``removal``) * ``doc`` * ``packaging`` * ``contrib`` * ``misc``
Related issues and pull requests on GitHub: :issue:
8066
.
Contributor-facing changes
-
Updated :ref:
contributing/Tests coverage <aiohttp-contributing>
section to show how we usecodecov
-- by :user:Dreamsorcerer
.Related issues and pull requests on GitHub: :issue:
7916
. -
The changelog categorization was made clearer. The contributors can now mark their fragment files more accurately -- by :user:
webknjaz
.The new category tags are:
* ``bugfix`` * ``feature`` * ``deprecation`` * ``breaking`` (previously, ``removal``) * ``doc`` * ``packaging`` * ``contrib`` * ``misc``
Related issues and pull requests on GitHub: :issue:
8066
.
Miscellaneous internal changes
-
Replaced all
tmpdir
fixtures withtmp_path
in test suite.Related issues and pull requests on GitHub: :issue:
3551
.
v3.9.1
==================
Bugfixes
-
Fixed importing aiohttp under PyPy on Windows.
#​7848 <https://github.com/aio-libs/aiohttp/issues/7848>
_ -
Fixed async concurrency safety in websocket compressor.
#​7865 <https://github.com/aio-libs/aiohttp/issues/7865>
_ -
Fixed
ClientResponse.close()
releasing the connection instead of closing.#​7869 <https://github.com/aio-libs/aiohttp/issues/7869>
_ -
Fixed a regression where connection may get closed during upgrade. -- by :user:
Dreamsorcerer
#​7879 <https://github.com/aio-libs/aiohttp/issues/7879>
_ -
Fixed messages being reported as upgraded without an Upgrade header in Python parser. -- by :user:
Dreamsorcerer
#​7895 <https://github.com/aio-libs/aiohttp/issues/7895>
_
v3.9.0
==================
Features
-
Introduced
AppKey
for static typing support ofApplication
storage. See https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config#​5864 <https://github.com/aio-libs/aiohttp/issues/5864>
_ -
Added a graceful shutdown period which allows pending tasks to complete
Configuration
π Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR has been generated by Renovate Bot.