cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon DopplerHQ

Implement `hide-secrets` flag for run command

Open remorses opened this issue 3 years ago • 4 comments

Implements #326

remorses avatar Aug 22 '22 16:08 remorses

I can add tests for ReplaceTransformer if you want, i copied that code from here

remorses avatar Aug 22 '22 16:08 remorses

I'm having difficulty understanding the practical use case for this, beyond demos. Why would a user want invalid values to be injected? I think a more pragmatic solution would be to support specifying an allowlist of secrets that should be injected (#322).

Piccirello avatar Aug 22 '22 19:08 Piccirello

This pr does not inject invalid values, it simply hides them from the terminal output, the env variables remain the same

some use cases

  • Making sure CI logs do not contain secrets (anyone that can see your logs could steal your secrets, very dangerous)
  • streaming on twitch or demos

remorses avatar Aug 22 '22 20:08 remorses