clang-format-lint-action icon indicating copy to clipboard operation
clang-format-lint-action copied to clipboard

fix: use custom strtobool if distutils not available

Open Vallishp opened this issue 1 year ago • 3 comments
trafficstars

  1. distutils not available from python 3.12 so clang-format-lint-action will fail.
  2. strtobool is relatively simple function, we can use this function if the import fails.

inspiration:

  1. https://stackoverflow.com/questions/42248342/yes-no-prompt-in-python3-using-strtobool

Vallishp avatar Sep 10 '24 06:09 Vallishp

Thanks, but this issue has already been resolved by pinning the Python version, can you reproduce the issue versions > v0.16 ?

DoozyX avatar Sep 10 '24 07:09 DoozyX

Thanks, but this issue has already been resolved by pinning the Python version, can you reproduce the issue versions > v0.16 ? tried with latest version. its working . thank you

Vallishp avatar Sep 10 '24 08:09 Vallishp

At some point we will need to change from the old python version, as it is a temporary solution. It is fine to think about how to migrate out.

echoix avatar Sep 10 '24 10:09 echoix

How about completely removing distutils? What if the --inplace command line argument is just a flag?

sebastien-rosset avatar Aug 13 '25 15:08 sebastien-rosset