Don Isaac

Results 36 comments of Don Isaac

As a sidenote: `json-to-ts` appears to be abandoned. There hasn't been a code change in over 7 months. See this [Snyk Advisor report](https://snyk.io/advisor/npm-package/json-to-ts)

> > use bit shifting > > Can you comment why it's better on the spot for future contributors. In this PR discussion, or in the code?

@Dunqing mind if I take this PR over?

Just did something similar for non-decimals in #3296. Decimals are up next

@overlookmotel I discovered that `Kind::Decimal`s are never floating point numbers. However, when I tried parsing them as an `i64` then casting the result to an `f64`, I found no performance...

> I don't believe so. > > > > > However, when I tried parsing them as an `i64` then casting the result to an `f64`, I found no performance...

@dalisoft please refer to this statement @Boshen made: https://github.com/oxc-project/oxc/pull/2214#issuecomment-1921636907

@Boshen if you'd like I can put something together

@Boshen can we please update this?

Closing this PR as it seems stale and unmergeable. @magic-akari feel free to re-open it when you're ready.