DonBruce64
Crash with custom resource types [1.12.2]
Refers to https://github.com/CleanroomMC/ModularUI/issues/157.
ModularUI adds a resource type which is gui theme json files. This mod only checks for vanilla resource types here and then just assumes its an item model here.
Why are you not just checking startsWith("models/item")?
This an extension of #1952 and i just saw that it was fixed in f8a47fee40205ac0e39765917cfdacc32036d068, but again its a very primitve fix and should be fixed with a startsWith("models/item") check.
That check won't work since that code needs to return JSON models, item pngs, objs, and other models that are used for MTS. Not just block JSONs. Or are you saying something else that I'm not understanding?
The problem is that you are assuming that the file starts with models/item/ if it ends with json. Why are you not checking for both in the if here.
Because I didn't realize exactly what I was loading. At one time, that system shunted in pack JSON. Now it only loads MC items, not blocks even since those are handled by the mod model loader. So yes, that is a proper check. Implemented. Thanks!