MinecraftTransportSimulator icon indicating copy to clipboard operation
MinecraftTransportSimulator copied to clipboard

sound config

Open liray-dev opened this issue 2 years ago • 7 comments

Adding new features to the sound config:

  • Randomization of sounds
  • Setting the range for sound playback
  • Doppler pitch effect switch.

Example: "sounds": [ { "name": "id:shot", "activeAnimations": [...], "forceSound": true, "minDistance": 2, "maxDistance": 32, "dopplerPitch": true, "randomSounds":["id:shot2","id:shot3","id:shot4"] } ]

liray-dev avatar Nov 05 '22 08:11 liray-dev

Good first PR, but a few comments on logic. I can for sure see some good use out of this.

DonBruce64 avatar Nov 05 '22 08:11 DonBruce64

I will update the wiki article about this.

dldev32 avatar Nov 05 '22 09:11 dldev32

Doppler effect should be opt-out instead of opt-in by the way

Ilya-torshov avatar Nov 05 '22 09:11 Ilya-torshov

Doppler effect should be opt-out instead of opt-in by the way

I mentioned that in the change requests. I gotchu mate.

DonBruce64 avatar Nov 05 '22 21:11 DonBruce64

Without these requirements, the PR will not be approved, do I understand correctly?

dldev32 avatar Nov 06 '22 05:11 dldev32

You understand incorrectly. See my notes on that requirement.

DonBruce64 avatar Nov 06 '22 09:11 DonBruce64

Once you check the max sound distance, I'm good. I want to make sure that no existing sounds play when you are more than 64 blocks away, since that will confuse PAs who had their sounds play that far previously. Horns and sirens and engines are the ones I would check.

Alternately, you could just check if both are 0, and if so, ignore distance entirely. TBH, that's a bit cleaner since it won't cause a new JSON parameter in every JSON. But I'm not married to the idea so I won't force you to do that.

DonBruce64 avatar Nov 06 '22 14:11 DonBruce64