MinecraftTransportSimulator icon indicating copy to clipboard operation
MinecraftTransportSimulator copied to clipboard

Animation type for hydraulics and other objects fixed at two locations

Open fsendventd opened this issue 2 years ago • 9 comments

Discussed on Discord.

fsendventd avatar Aug 21 '22 21:08 fsendventd

Smells like trig that @DrprofLuigi might be able to help with. I hate trig as much as Indy hates snakes.

DonBruce64 avatar Aug 23 '22 02:08 DonBruce64

It's something that could be approximated (take a look at the UNU Solenodon), however more accurate animation would necessitate trig function suffixes for more variables. Though, perhaps something with VMs could be done...

VMs use translations to apply their changes. What if rotation VMs execute trig math? @DonBruce64, if you can point me to the file that handles VM math processing, I might be able to whack something together 🤔

DrprofLuigi avatar Aug 23 '22 02:08 DrprofLuigi

@DrprofLuigi You'll wanna go after the code that does variable processing in general, not the VMs. VMs just run code though the animation system and store that result into a variable on the entity. So https://github.com/DonBruce64/MinecraftTransportSimulator/blob/bd95182e8ecb9f43367528d0cb72925d3e0b8f5e/src/main/java/minecrafttransportsimulator/entities/components/AEntityD_Definable.java#L644

DonBruce64 avatar Aug 23 '22 03:08 DonBruce64

I'm going to hold off on this personally until someone releases a model that can use this. I an't coding trig for future content. I hate it enough for current content.

DonBruce64 avatar Sep 01 '22 04:09 DonBruce64

ping seagull. he has a bed that is already released that this could benefit

LauraDarkez avatar Sep 01 '22 05:09 LauraDarkez

right now the hydraulic piston clips through the floor of the bed when lifting

LauraDarkez avatar Sep 01 '22 05:09 LauraDarkez

actually, there is something it would benefit thats publically released. franz's giant artillery cannon

LauraDarkez avatar Sep 01 '22 05:09 LauraDarkez

My farming equipment use hydraulic cylinders. Almost all of them have cylinders on them somewhere but only some (just one currently) actually have animations for them...

Colt44Magnum avatar Sep 03 '22 00:09 Colt44Magnum

I'm gonna punt this ticket to @DonBruce64 for a PR, since he's working on engine and rotational animations right now. 1-month outsourcing timeline starts now.

DonBruce64 avatar Oct 01 '22 05:10 DonBruce64

I think the ping above was for @DrprofLuigi and I mis-clicked. But he's not working on these, and probably never will given our convos, so I'm going to table this for the moment. I think it's a good idea, but I don't have the brain to do it.

DonBruce64 avatar Mar 26 '23 01:03 DonBruce64