TimelineExtension icon indicating copy to clipboard operation
TimelineExtension copied to clipboard

backgroundImage not displayed in Timeline

Open da2x opened this issue 6 years ago • 43 comments

Pages with og:image doesn’t show image in Timeline. Not sure what adaptive card is being used by Edge. Looked over the documentation but still not sure what is missing.

da2x avatar Jul 12 '18 22:07 da2x

It was working before. Did this pull request maybe break it?

https://github.com/DominicMaas/TimelineExtension/pull/14

DominicMaas avatar Jul 12 '18 23:07 DominicMaas

Looking through my activity history, I don’t see it working at any point in time.

da2x avatar Jul 12 '18 23:07 da2x

Huh, I had it working on both Chrome and Firefox six or so hours ago.

DominicMaas avatar Jul 12 '18 23:07 DominicMaas

I just tested Vivaldi, Chrome, and Firefo’. None of them load background images for any of these(or any other random page) despite background images being detected correctly:

  • https://www.neowin.net/news/latest-firefox-nightly-build-adds-support-for-windows-10-dark-theme
  • https://www.ctrl.blog/entry/firefox-u2f-google
  • https://www.keycdn.com/blog/pop-in-melbourne-perth/

da2x avatar Jul 12 '18 23:07 da2x

Just checked with the latest commits, works for me. I wonder if there's a setting somewhere that's disabling the images?

DominicMaas avatar Jul 13 '18 05:07 DominicMaas

I see only active activity, that one is with no background. Just like Edge.

I think the activity isn't saved, when I go to earlier today- see all activity . Then I see only edge and Phpstorm

810 avatar Jul 14 '18 21:07 810

I assume that you have logged into your Microsoft Account (in the extension)?

DominicMaas avatar Jul 14 '18 21:07 DominicMaas

Yes, the project rome is working perfectly. Only I can't see the google activity webpages on "See all activity"

On the Microsoft privacy activity I can't see it. test

810 avatar Jul 14 '18 21:07 810

Hmmm. Alright, could you go to the Chome extension page (chrome://extensions). Under this extension (Windows Timeline Support) there is a link that says "background page". Could you please click on it, navigate to the console and take a screenshot (or copy paste any errors that are appearing).

DominicMaas avatar Jul 14 '18 21:07 DominicMaas

test

810 avatar Jul 14 '18 21:07 810

Does nothing show when you navigate to other pages? Try searching for something on Google, keep in mind you have to wait ~8 seconds after page load before the extension sends an activity.

DominicMaas avatar Jul 14 '18 21:07 DominicMaas

yes, nothing is stored.

810 avatar Jul 14 '18 21:07 810

On the "Default Levels" drop down box (Dev Tools), can you tick "Verbose" and see if anything is displayed?

If not, try removing the extension and adding it again (as a potential temp fix), I'll add some more logging in the mean time.

DominicMaas avatar Jul 14 '18 21:07 DominicMaas

ok on Stable I get this error now:

graph.microsoft.com/v1.0/me/activities/https%3A__login.live.com_ppsecure_post.srf%3Fwa%3Dwsignin1.0%26rpsnv%3D13%26ct%3D1531605334%26rver%3D6.7.6643.0%26wp%3DMBI_SSL%26wreply%3Dhttps%3A%252F%252Faccount.microsoft.com%252Fauth%252Fcomplete-signin%253Fru%253Dhttps%25253A%25252F%25252Faccount.microsoft.com%25252Fprivacy%25253Fru%25253Dhttps%2525253A%2525252F%2525252Faccount.microsoft.com%2525252Fprivacy%2525252Factivity-history%26lc%3D1043%26id%3D292666%26lw%3D1%26fl%3Deasi2%26contextid%3D75C98387C6B3EC9A%26bk%3D1531605337%26uaid%3Dc75ceaebb9c345ccb9c3a784357b5219%26pid%3D0:1 Failed to load resource: the server responded with a status of 400 (Bad Request)

810 avatar Jul 14 '18 22:07 810

test1

810 avatar Jul 14 '18 22:07 810

Sometimes those errors are produced (certain urls contains characters that break everything), but it looks like the other requests were successful, (https://www.ajax.nl/home and https://account.microsoft.com/privacy). Do these not appear in Windows Timeline?

Another thing I can think of is restarting explorer.exe on your PC (this also restarts timeline - messy, but it has worked for me in the past).

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

No, I can't see them on the timeline or on https://account.microsoft.com/privacy/activity-history?view=browse

810 avatar Jul 14 '18 22:07 810

I think this is the issue:

"appActivityId":"https%3A__www.geenstijl.nl_"

810 avatar Jul 14 '18 22:07 810

I think this is the issue:

That is expected.

da2x avatar Jul 14 '18 22:07 da2x

Yeah that's usually the id that works (I'm going to push an update that base64 encodes the url anyway, to avoid the bad request errors). But it looks like everything posted successfully.

Only thing I can think of is if the time zone, or created time is wrong (if it's in the future it may not show anywhere, but still exist).

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

i have change it to let activityId = webActivity.activityOriginUrl; reloaded the extension and reload chrome, and now i can see it on the activities

810 avatar Jul 14 '18 22:07 810

Could you pull the latest commit and see if that also works?

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

Wait, I made a mistake, just need to fix it quickly

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

Okay, now try.

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

Yes, its working now. Only the time is set to utc. So for us its missing 2 hours. (new day)

810 avatar Jul 14 '18 22:07 810

Now on issue, i still can't see the og:image

810 avatar Jul 14 '18 22:07 810

Could you navigate to https://github.com/DominicMaas/TimelineExtension, and copy the data payload (starts with {"appActivityId"... - is written into the console) and paste it here?

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

"activitySourceHost":"github.com","createdDateTime":"2018-07-14T22:51:10.243Z","lastModifiedDateTime":"2018-07-14T22:51:10.555Z","id":"5044551257986403992","appActivityId":"aHR0cHM6Ly9naXRodWIuY29tL0RvbWluaWNNYWFzL1RpbWVsaW5lRXh0ZW5zaW9u","activationUrl":"https://github.com/DominicMaas/TimelineExtension","appDisplayName":"Google Chrome","userTimezone":"Europe/Berlin","fallbackUrl":"https://github.com/DominicMaas/TimelineExtension","expirationDateTime":"2018-08-13T22:51:10.243Z","status":"active","visualElements":{"displayText":"DominicMaas/TimelineExtension","description":"https://github.com/DominicMaas/TimelineExtension","content":{"$schema":"http://adaptivecards.io/schemas/adaptive-card.json","type":"AdaptiveCard","backgroundImage":"https://avatars3.githubusercontent.com/u/5589453?s=400&v=4","body":[{"type":"Container","items":[{"type":"TextBlock","text":"DominicMaas/TimelineExtension","weight":"bolder","size":"large","wrap":true,"maxLines":3},{"type":"TextBlock","text":"https://github.com/DominicMaas/TimelineExtension","size":"default","wrap":true,"maxLines":3}]}]},"attribution":{"iconUrl":"https://assets-cdn.github.com/favicon.ico","alternateText":"github.com","addImageQuery":false}},"[email protected]":"https://graph.microsoft.com/v1.0/$metadata#users('schumacher1986%40hotmail.com')/activities('5044551257986403992')/historyItems","historyItems":[{"status":"updated","userTimezone":"Europe/Berlin","createdDateTime":"2018-07-14T22:51:10.243Z","lastModifiedDateTime":"2018-07-14T22:51:10.243Z","id":"e071f9c6-6e20-4b51-9730-61d465ee8b69","startedDateTime":"2018-07-14T22:51:10.042Z","lastActiveDateTime":"2018-07-14T22:51:10.042Z","expirationDateTime":"2018-08-13T22:51:10.243Z","activeDurationSeconds":0}]}

810 avatar Jul 14 '18 22:07 810

No background image in the Timeline card? Can you access the following url and see the image?

https://avatars3.githubusercontent.com/u/5589453?s=400&v=4

DominicMaas avatar Jul 14 '18 22:07 DominicMaas

its now fluent, maybe its an api issue .

I can see the image, and the data payload looks ok for me.

810 avatar Jul 14 '18 23:07 810