Albert Domenech

Results 91 comments of Albert Domenech

As a generic comment I would also suggest to add the interface `IEquatable` to those classes that override `Equals` and `GetHashCode`.

Sorry for the delay but this is a quite big PR and it will take some time for me to review it all.

> Finally think this is ready for review. > > Also noticed that you're merging the changes instead of squashing & merging. Just wondering if there a reason for this?...

I left 2 minor comments in the PR, I'm not sure that I grasped the whole implementation but it does not break anything and adds useful features to the project...

Hi @KiisMyGun, The issue seems to be when the Hatch is been written, I'll open a branch to take care of this issue. Thanks for reporting the bug.

Hi @zxxiao2012, The major axis property is called `Endpoint`: ```C# /// /// Endpoint of major axis, relative to the center (in WCS). /// [DxfCodeValue(11, 21, 31)] public XYZ EndPoint {...

Hi @farshadvl, As @Revan1985 pointed out your piece of code seems to be incomplete for us to help, but for what you are saying you are trying to read information...

I've also noticed that the writer closes the stream even if the `CloseStream` flag is set to false, I'll open a branch to fix it, in the mean time the...

Hi @mdmozibur, If the change is minimal I won't have a problem to merge the PR, although I think is beneficial for other projects to update to higher versions of...

Hi @TheRaikoz I'll open a PR to add this feature to the project. Thanks for reporting it!