Rework Multileader

[mme1950]

We recently implemented classes and a reader to handle MultiLeader entities in ACadSharp.

Using the MultiLeader data we learned a lot about the confusing data structures and values. So we try do document the properties to support usage.

And we found some issues, in particular bad or inconsistent naming:

• [x] #273
• [x] Misspelled enum identifier in MultiLeaderPropertyOverrideFlags
• [x] MultiLeader/MultiLeaderAnnotContext: TextAlignment property etc.
• [x] MultiLeader/MultiLeaderAnnotContext: AlignmentType, BlockContentConnection property.
• [x] MultiLeaderAnnotContext: bad property visibility. no setters for IList properties
• [x] MultiLeaderAnnotContext: Property naming
• [x] MultiLeaderAnnotContext: Should Location, Rotation doubled to TextLocation, TextRotation and ContentBlockLocation, ContentBlockRotation?

Note: This issue infers a breaking change.

Branch created: https://github.com/nanoLogika/ACadSharp/tree/20240225_mme_MultiLeader_rework

[mme1950]

TextAlignment etc.

The standard value for the TextAlignment property is defined in the MultiLeaderStyle object in the field with the DXF group code 176. This field can have the value 0. So it can be assumed that the enum values are 0=Left, 1=centered, 2=right.

The MultiLeader entity has a field with the DXF group code 175 which is unknown according to the OD_S_DWG documentation, but documented as Text Alignment Type in the DXF reference AC1024 and newer. This field can have the values 0, 1, 2. So it can be assumed that the enum values are 0=Left, 1=centered, 2=right.

A field with the same meaning is found in the MultiLeaderAnnotationContext with the DXF group code 176 documented as Text Align Type with the enum values 0=Left, 1=centered, 2=right in the OD_S_DWG documentation.

Both should be named as TextAlignment.

The multileader entity has a field with the DXF group code 179 documented as Justification in the OD_S_DWG with the values 1=Left, 2=centered, 3=right, documented as Text Attachment Point in the DXF reference.

A field with the same meaning is found in the MultiLeaderAnnotationContext with the DXF group code 171 documented as Alignment with the enum values 1=Left, 2=centered, 3=right in the OD_S_DWG documentation, documented as Text Attachment in the DXF reference.

Both should be named as TextAttachmentPoint.

In AutoCAD the text alignment can be specified in MutliLeaderStyle dialog. In the property grid of the multileader entity appears one field Alignment.

In DWG and DXF the field with the group code 175 in the multlieader has always the value 0=left, regardless of the Alignment selected in the property grid.

MultiLeaderAnnotationContex.TextAlignment returns the value set in the property grid. We found in all samples that the values returned by MultiLeader.TextAttachmentPoint and MultiLeaderAnnotationContex.TextAttachmentPoint are equal and consistent with MultiLeaderAnnotationContex.TextAlignment.

[mme1950]

Location, Rotation

DXF uses different group codes for

• Text Location: 11, 22, 32
• Block Content Location: 15, 25, 35 and
• Text Rotation: 42
• Block Content Rotation: 46

We decided to implement one Location property for both, and one Rotation property for both.

@DomCR Do you think this is OK?

[mme1950]

MultiLeaderStyle/group code 177 MultiLeader/group code 176 MultiLeaderAnnotContext/group code 177

are documented as Attachment Type or as Block Content Connection with enum values AttachmentType: CenterExtents = 0, InsertionPoint = 1 or BlockContentConnectionType: BlockExtents = 0, BasePoint = 1

are associated with the MultiLeaderPropertyOverrideFlags.BlockContentConnection flag.

--> Use equal property name in BlockContentConnection in MultiLeaderStyle, MultiLeader, MultiLeaderAnnotContext --> Use BlockContentConnectionType, AttachmentType is deleted.

[DomCR]

Location, Rotation

We decided to implement one Location property for both, and one Rotation property for both.

I don't think is a good solution for the project, but if we have the certainty that this properties are exactly the same we could implement 2 private fields and return the same for each one of them (the same logic would be applied for the set).

The main reason why I think that we should not merge them is because the DxfMapper may not work as expected if we add multiple codes to the same value.

We also had a similar issue with MText:

• https://github.com/DomCR/ACadSharp/pull/203

In this case we though that Rotation and Alignment point were correlated but at the end that was not the case.

Let me know what you think about my approach.

[mme1950]

A MultiLeader has ether a text label or a block content having a Location and a Rotation. TextLocation and BlockContentLocation are never relevant at the same time and they are not related. I expected that the DxfMapper uses the group-code assignment, but I did not know. It is no problem to implement separate properties for the text-label case and the content-block case.

[mme1950]

When this issue is completed we will have renamed several properties. But I think this is acceptable