why COMPANY_HIDE_INACTIVE_IN_COMBOBOX not set by default ?

[vmaury]

Bug

During a training on Dolibarr, I found something appearing to be a bug You are on a product, buy price tab When you add a price, desactivated companies are present in the furnisher select combo When you validate and a desactivated company was selected, the new price is not displayed in the price's list above (it's in database) That's because the list use function list_product_fournisseur_price (fournisseur.product.class.php), that have a join in the sql to societe and a has a where condition AND s.status = 1

So I suggest that by default COMPANY_HIDE_INACTIVE_IN_COMBOBOX is set to 1 Or in function list_product_fournisseur_price the condition AND s.status = 1 is only added if COMPANY_HIDE_INACTIVE_IN_COMBOBOX = 1

Environment Version

All

Environment OS

Independant

Environment Web server

No response

Environment PHP

No response

Environment Database

No response

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

No response

[github-actions[bot]]

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).