dolibarr icon indicating copy to clipboard operation
dolibarr copied to clipboard

NEW: Membership rework

Open ymollard opened this issue 2 years ago • 1 comments

NEW | Allow memberships of any duration (from few seconds to unlimited

No longer defaulting to 1 year Unlimited membership are displayed as such in UI

NEW | Free-of-charge memberships registered online can also expire and get renewed by keeping the renewal history

Such memberships registrations also create a Subscription object with amount = 0 for traceability

NEW | Via the UI, invite the user validating members to create a manual subscription

For more traceability

NEW | Allow membership counts to be public if the option is selected

FIX | Fixed logic of memberships: expired, paid and subject-to-payment are evaluated independently

In particular, fixes incorrect states for any-amount subscriptions

FIX | Sorting tables on rowid is a numeric sort

FIX | Addition of 1y delays to time during leap years

Includes the associated unit test

FIX | Various fixes in UI or membership model

ymollard avatar Aug 03 '22 02:08 ymollard

This PR follows https://github.com/Dolibarr/dolibarr/pull/21412

Yet to be done:

  • Allow to renew existing subscriptions rather than telling the visitor to contact the association in that case
  • Allow to upload profile picture instead of requesting a link to an online picture (Since there is no captcha and this form is public, is there a risk in allowing visitors to upload a picture here?)
  • Send membership cards by e-mail after a membership validation/payment (only the invoice is currently sent)
  • Allow members to self-subscribe by paying by cash/check with validation of an authorized user
  • Allow enclosed files as extra fields
  • Manage compulsory extra fields according to member types

ymollard avatar Aug 03 '22 02:08 ymollard

Can you submit change in smaller PR. It is easier and more secured to merge PR when they are smaller and atomic (1 PR = 1 feature or 1 fix)

eldy avatar Aug 26 '22 17:08 eldy

Can you submit change in smaller PR

I have submitted https://github.com/Dolibarr/dolibarr/pull/21910 with only fixes, first.

ymollard avatar Aug 26 '22 18:08 ymollard