dokploy icon indicating copy to clipboard operation
dokploy copied to clipboard

Modify README.md to support Chinese

Open OSNewbie opened this issue 1 year ago • 14 comments

[README]: Modify README.md to support Chinese language display.

OSNewbie avatar May 10 '24 00:05 OSNewbie

Modify README.md to support Chinese language, convenient for Chinese users to browse and watch, the developers hope that Chinese language interface can be labeled in the README introduction page.

OSNewbie avatar May 10 '24 00:05 OSNewbie

@kwxmxb can you revert the changes from the original Readme? and just let the chinese version?

Siumauricio avatar May 11 '24 04:05 Siumauricio

@kwxmxb can you revert the changes from the original Readme? and just let the chinese version?

The third version is that in the second revision I accidentally changed the name, which caused this md intro profile not to show up and I had to add it again, namely

https://github.com/Dokploy/dokploy/pull/68/commits/eb055687989c5d3e8e1b490b4a1d61e0c6778811

OSNewbie avatar May 11 '24 08:05 OSNewbie

@kwxmxb can you revert the changes from the original Readme? and just let the chinese version?

The third version is that in the second revision I accidentally changed the name, which caused this md intro profile not to show up and I had to add it again, namely

eb05568

The referenced file has been deleted and is not available.

Originally, I wanted to put a character in front of the md file, such as zh CN, etc. Well, it may have been the modification of the default md introduction file that caused me to recreate it. Actually, I had already modified the md introduction file the first time, but it was the second and third modifications that caused the problem.

OSNewbie avatar May 11 '24 08:05 OSNewbie

Please do not translate the README.md file, just add the file README-zh.md

@Siumauricio I think README needs, README multi-language links, contribution file links, contributor list, License

like this:https://github.com/jaywcjlove/awesome-mac/blob/5df4431ec9ca2dbfe6acd6826697b6e1eb901038/README.md

hehehai avatar May 11 '24 09:05 hehehai

It's been completely reworked for the final version. Please comment if you think it should be improved. https://github.com/Dokploy/dokploy/pull/68/commits/156cac288b6be162b125d291960b3cc7747d2f62

OSNewbie avatar May 11 '24 10:05 OSNewbie

Please do not translate the README.md file, just add the file README-zh.md

@Siumauricio I think README needs, README multi-language links, contribution file links, contributor list, License

like this:https://github.com/jaywcjlove/awesome-mac/blob/5df4431ec9ca2dbfe6acd6826697b6e1eb901038/README.md

They listen to your opinion and name the Chinese introduction file according to README-zh.md.

OSNewbie avatar May 11 '24 10:05 OSNewbie

@kwxmxb can you revert the changes from the original Readme? and just let the chinese version?

The third version is that in the second revision I accidentally changed the name, which caused this md intro profile not to show up and I had to add it again, namely

eb05568

I decided to name the README-zh.md Chinese introduction with this

https://github.com/Dokploy/dokploy/pull/68/commits/156cac288b6be162b125d291960b3cc7747d2f62

OSNewbie avatar May 11 '24 10:05 OSNewbie

Sorry, wrong point, I will wait patiently for the maintainer to review the draft.

OSNewbie avatar May 11 '24 10:05 OSNewbie

@kwxmxb @Siumauricio I think the text content is ok, but there are some problems with the formatting and it needs to be consistent with the English document

image

hehehai avatar May 11 '24 14:05 hehehai

@kwxmxb Submitting, please do not delete the README.md file

hehehai avatar May 11 '24 14:05 hehehai

You are right @hehehai

@kwxmxb can you please do the following:

  1. Can you please revert the main Readme.md, currently the file is deleted.
  2. Fix the requested changes by @hehehai that is missing some content or mispelled
  3. Can you also add this, a link that points to the different Readmelanguages? image

Siumauricio avatar May 11 '24 17:05 Siumauricio

@Siumauricio May I ask, is the default md translation file based on the official English or my modified Chinese? I don't quite understand.

OSNewbie avatar May 12 '24 01:05 OSNewbie

@Siumauricio May I ask, is the default md translation file based on the official English or my modified Chinese? I don't quite understand.

I'd like to ask you how that icon of yours to jump to a certain translation screen is implemented? I don't know how to do it, so I'm asking.

OSNewbie avatar May 12 '24 01:05 OSNewbie

@Siumauricio May I ask, is the default md translation file based on the official English or my modified Chinese? I don't quite understand.

Yes, the English readme file is the default.

Siumauricio avatar May 12 '24 02:05 Siumauricio

@Siumauricio May I ask, is the default md translation file based on the official English or my modified Chinese? I don't quite understand.

Yes, the English readme file is the default.

Why does it feel like the fonts are not displaying consistently? I don't know why, but it still hasn't changed. I don't know if it's a - problem or a ** problem between these two symbols.

OSNewbie avatar May 12 '24 02:05 OSNewbie

@Siumauricio I've changed it. This should be fine. Well, it's a bit complicated, really.

Default md translation file https://github.com/Dokploy/dokploy/pull/68/commits/e8d50f3c29d7ed13ad40914cb54afb22a5e62e87

Chinese translation md file https://github.com/Dokploy/dokploy/pull/68/commits/428156579ddb88bccf9a33931d6ec7c10367fbe6

OSNewbie avatar May 12 '24 02:05 OSNewbie

@Siumauricio I've changed it. This should be fine. Well, it's a bit complicated, really.

Default md translation file e8d50f3

Chinese translation md file 4281565

Chinese translation of the actual location of the md file https://github.com/Dokploy/dokploy/blob/428156579ddb88bccf9a33931d6ec7c10367fbe6/README-zh.md

It seems that it can only jump to the submitted code page to access the actual file page.

OSNewbie avatar May 12 '24 02:05 OSNewbie

Thanks @kwxmxb

Siumauricio avatar May 12 '24 04:05 Siumauricio

Thanks @kwxmxb

My default md, the translation file, English points to your official default English description, this may be redundant, I'm not sure, you can change it.

OSNewbie avatar May 12 '24 06:05 OSNewbie

@Siumauricio just discovered a problem, this PR did not merge the commit 🤯

hehehai avatar May 13 '24 00:05 hehehai

@kwxmxb what do you mean? I see the changes on canary branch

Siumauricio avatar May 13 '24 00:05 Siumauricio

just discovered a problem, this PR did not merge the commit 🤯

https://github.com/Dokploy/dokploy/commits/canary/

OSNewbie avatar May 13 '24 03:05 OSNewbie

@kwxmxb what do you mean? I see the changes on canary branch

Since most of the contributors are replicating the project, so since you're not synchronizing the replicas, you don't see the updates to that merged commit of his.

OSNewbie avatar May 13 '24 03:05 OSNewbie

This commit should be Squash!

hehehai avatar May 13 '24 04:05 hehehai

Dokploy panel language, which languages are supported I would like to ask

OSNewbie avatar May 13 '24 11:05 OSNewbie