reactist icon indicating copy to clipboard operation
reactist copied to clipboard

TextLink: default CSS variable choice seems off

Open scottlovegrove opened this issue 3 years ago • 0 comments

🐛 Bug report

Current behavior

When using the TextLink component, by default it is using --reactist-chromatic-content-blue for its color value, the problem with this is to override that to a different colour, you have to then put something like --reactist-chromatic-content-blue: red which seems counter intuitive.

I wonder if there should be a better CSS variable for this color that by default can use that variable, but overriding it means you wouldn't be overriding an existing colour value.

Steps to reproduce the bug

I just have

<TextLink href={selectedFilm.filmLink()} openInNewTab>
    Film details
</TextLink>

Which gives me the following css image

I have overridden the blue value to be something else now, but it just seems odd that I have to override a blue value to be able to use some other colour.

Expected behavior

It should use a more sensibly named CSS variable.

Environment

  • @doist/reactist version: 11.0.0
  • react version: 17.0.2
  • Browser: Chrome

scottlovegrove avatar Nov 15 '21 13:11 scottlovegrove