acwj icon indicating copy to clipboard operation
acwj copied to clipboard

Part 8: new token related issue

Open Psycho7 opened this issue 5 years ago • 2 comments

After introducing new tokens, many places need modification of course. It's not hard for someone to realize we need to change defs.h and scan.c, but some files are easily ignored at first.

For example the following change, this one really took me a lot of time to figure out why my code wasn't working as expected 😭 https://github.com/DoctorWkt/acwj/blob/b11b269c71727297b367203eaed164364291db16/08_If_Statements/expr.c#L78 https://github.com/DoctorWkt/acwj/blob/b11b269c71727297b367203eaed164364291db16/08_If_Statements/expr.c#L98

Psycho7 avatar Feb 02 '20 07:02 Psycho7

I'm sad that you had problems here. Can you suggest an improvement I can make to the Readme or code which would have helped? Thanks.

DoctorWkt avatar Feb 12 '20 23:02 DoctorWkt

Hi @DoctorWkt . Probably just mentioning the changes in readme would be great.

Psycho7 avatar Feb 12 '20 23:02 Psycho7