node-steam-session icon indicating copy to clipboard operation
node-steam-session copied to clipboard

Feature required: update `helpers.getSpoofedHostname` to match `helpers.createMachineId` behavior

Open Sadzurami opened this issue 1 year ago • 2 comments

Implementation now works fine, but would be better to match behaviour like createMachineId, in other words - by account name.

Right now it looks strange, because by default all accounts has unique machineid, but the same clientFriendlyName.

Sadzurami avatar Sep 03 '24 06:09 Sadzurami

A machine name is also required for QR sessions, where an account name isn't known prior to session start. We could use the account name as the seed for the machine name and otherwise use the local hostname for QR logins though.

DoctorMcKay avatar Sep 03 '24 06:09 DoctorMcKay

A machine name is also required for QR sessions, where an account name isn't known prior to session start. We could use the account name as the seed for the machine name and otherwise use the local hostname for QR logins though.

I guess, would be better to make this. Also, would be better to make device-name alphabet longer, include nums.

I can make pr.

Sadzurami avatar Sep 03 '24 06:09 Sadzurami