DoctorKrolic

Improve codegen for concatenation of `string` and `char` (attempt 2)

52

Closes https://github.com/dotnet/roslyn/issues/66827 This PR takes approach suggested in https://github.com/dotnet/roslyn/pull/70971#issuecomment-1886329321 by @AlekseyTs with some implementation details chaged. E.g. it turned out is's easier to handle `constantChar.ToString()` pattern in `ConvertConcatExprToString` rather than...

Right now in order to test diagnostic suppressor it is required to use code instead of more visual markup. It might be a good thing to add a pair of...

Syntax visualizer sometimes stops working after opening color picker for classified spans

1

**Version Used**: Latest main (https://github.com/dotnet/roslyn/commit/1113a49ad60c6c4d7ccd508f86c854e856bdd1d9) **Steps to Reproduce**: 1. Open VS with the empty project and a blank file 2. Open roslyn Syntax visualizer 3. Paste this code: ```cs new...

Scary Nuget warnings when installing a testing package for .NET 7

5

**To reproduce:** 1. Create .NET 7 console app 2. Install `Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit` v1.1.1 (the latest currently available) 3. Your `.csproj` should look like this after 2 previous steps: ```csproj Exe net7.0...

Example test: https://github.com/dotnet/roslyn/blob/6acaa7b7c0efea8ea292ca26888c0346fbf8b0c1/src/EditorFeatures/CSharpTest/MakeLocalFunctionStatic/PassInCapturedVariablesAsArgumentsCodeFixProviderTests.cs#L355-L383 List of all supported annotations by the legacy test framework: https://github.com/dotnet/roslyn/blob/6acaa7b7c0efea8ea292ca26888c0346fbf8b0c1/src/EditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionOrUserDiagnosticTest.cs#L620-L623 I expect some kind of markup for specifying these annotations in code action test. If these...

We don't need documentation mode to be on

2

This line enables "documentation mode" for our source folder: https://github.com/tintoy/msbuild-project-tools-server/blob/3ae2ece400a46609af76e18579bcb835f28d4f4f/src/Directory.Build.props#L5 This means that C# warns on _every_ undocumented public member of any type in our main codebase. While I agree...

Showing completions after trigger chars can be unstable

8

I managed to get a consistent repro of https://github.com/tintoy/msbuild-project-tools-server/issues/52#issuecomment-1627449845  _`.csproj` with this content is the only MSBuild-related file in the project_

Reconsider usage of enviroment variables

1

The main idea of a language server protocol is to provide intellisense in as client-independent way as possible. In practice, however, language servers do often contain client-dependent elements. One of...

Report document symbols in a tree view manner

7

As of now, document symbols are reported as flat array, e.g. for this `.csproj`: ```csproj Exe net7.0 enable enable preview true ``` ... reported symbols look like this:  However,...

Completions don't work properly when you just start typing

10

This is better to show than explain:  For some reason the first letter isn't a part of completion session. However, if you first manually trigger completions and then start...