Jonathan Ehwald
Jonathan Ehwald
> p.s. happy to spin up a minimal reproduction if that helps! @jpdriver it would be nice if you could share your `app.config.js` file. So far I have not seen...
Thank you very much @jpdriver. I just identified the issue and I'm working on a PR for it. I will post an explanaiting in a bit.
@dylancom (cc: @mikehardy) unfortunately we need to discuss the configuration workflows again. The expo config plugin always works as expected (even in the repro provided in this issue), but the...
@jpdriver You're correct that the expo config plugin does not require any changes. It already fully supports app.json, app.config.js, and app.config.ts. The issue here is caused by build.gradle. The build.gradle...
> which seemed to build correctly but then crashed on app launch.. This is could be because the admob app ids in your app.config.js are not valid. (you can try...
@dylancom if we're fine with `build.gradle` and `ios_config.sh` only warning about missing admob app IDs instead of failing the build, we can ignore [my super long comment](https://github.com/invertase/react-native-google-mobile-ads/issues/620#issuecomment-2276006062) and close this...
> Just updated this to custom info classes get injected into extensions as well. Oh, great catch! It would be great to have a test case checking that the custom...
We could make this an option. Shouldn't be too hard either since we have access to the "lexicographic sort schema" function [via graphql-core](https://graphql-core-3.readthedocs.io/en/latest/modules/utilities.html#graphql.utilities.lexicographic_sort_schema).
> Hi! I'd like to work on this issue for Hacktoberfest. Could you please confirm if this issue is still relevant? It's still relevant, feel free to work on it!
> After talking to [@patrick91](https://github.com/patrick91) and [@DoctorJohn](https://github.com/DoctorJohn), it makes more sense to divide the errors into PreExecutionErrors and Errors (maybe?) We cleared up some confusion around this in #3947. The...