ember-router-scroll icon indicating copy to clipboard operation
ember-router-scroll copied to clipboard
verified publisher icon DockYard

Provide utils if don't use EmberRouter

Open snewcomer opened this issue 6 years ago • 2 comments

After the major upgrade, ember-router-scroll now by default extends EmberRouter. If this doesn't work for some apps that need to extend something other than EmberRouter, we can provide util functions to be called in the constructor to setup the listeners.

I'm unsure who this might apply to so filing an issue for now.

Ref #234

snewcomer avatar Jan 17 '20 21:01 snewcomer

I'm unsure who this might apply to so filing an issue for now.

I just came across an IMHO very important use case for having a different solution other than extending from EmberRouter, as @embroider/router also requires this. Having said that, it seems that #255 will achieve the same, without having to expose utils...

simonihmig avatar Nov 17 '20 17:11 simonihmig

Seems like we can close this issue now that version 4 is out which extends the router service instead of using a custom router class?

rahulk94 avatar Mar 11 '22 04:03 rahulk94