ember-composable-helpers icon indicating copy to clipboard operation
ember-composable-helpers copied to clipboard

Configuration not honored in a yarn workspace

Open jonpitch opened this issue 7 years ago • 1 comments
trafficstars

Version

2.1.0

Test Case

https://github.com/jonpitch/ember-composable-helpers-yarn-workspace

Steps to reproduce

Expected Behavior

The only helper included is sort-by

Actual Behavior

All helpers are included

Further detail

The yarn workspace has an Ember addon and application. The Ember addon has ember-composable-helpers as a dependency and the Ember application consumes the addon.

Modifying this to use this.parent.app.options resolves the issue, but that seems off. I have some bandwidth to issue a PR if needed, but I could use some guidance on a possible solution or if I'm doing something wrong.

jonpitch avatar Aug 03 '18 01:08 jonpitch

I think you should be able to configure ember-composable-helpers in the addon. That way the app doesn't need to know about which helpers the addon uses.

bertdeblock avatar Mar 06 '21 17:03 bertdeblock