Pedro

Results 86 comments of Pedro
trafficstars

> So, no, it does not need a rebase and already targets 3.2.x with only one added commit, lgtm okay, when try test i cannot set the branch in my...

maybe im confuse but this cannot help or is totally different task? https://docs.gradle.org/current/userguide/publishing_maven.html

> This does indeed fix the problem with fireworks. > > The issue with the causing entity for some other explosions (i.e. TNT) being wrong is still a thing, though....

@TonytheMacaroni PR updated for avoid the customCausingMethod set the value if. - The customCausingEntity is already set - The causingEntity is the same than the entity passed - The directEntity...

> That would fix the issue with TNT, but still, the call to `customCausingEntity` isn't needed in `Explosion`? That's the only area that that method causes this specific issue. >...

> Just to note, I don't have an account to view the upstream comments you're referring to. oh... - The customCausingEntity was make for allow the old static damager set...

Maybe the new info about the Windows Defender can be in a "info" box before the caution about mnt? also mention this only apply for people using Windows Defender and...

> should be more accurate now > > EDIT: Also i think it would be worth adding an index to the Contributing.md as especially new contributors might want to search...

In a fast check i wanna ask.. this make the thing i mention in upstream about now DamageEvent#getDamager is not the same than DamageSource#getEntity? if that is the case this...

For explosions looks is working fine. For tests cases where now is used customCausingEntity the DamageSource has null direct/causing entity causing like i said this sounds inconsistent.. and make a...