Dn-FamiTracker icon indicating copy to clipboard operation
Dn-FamiTracker copied to clipboard

Song/Module naming inconsistency

Open nstbayless opened this issue 1 year ago • 3 comments

It seems that the term "Module" has been replaced with "Song" in some instances. Compare this screenshot of 0CC (left) and Dn (right):

image

Similarly, CFamiTrackerDoc::GetModuleName is now CFamiTrackerDoc::GetSongName, and a few other fields are renamed as well.

This doesn't really make sense, as there can be multiple songs in a module, and the term song is already used elsewhere to refer to those.

nstbayless avatar Mar 19 '23 22:03 nstbayless

Also, there are a couple instances in the codebase of "Song" being replaced with "Track," also inconsistently. This is surprising because in "Track" is also used to refer to Channels sometimes.

For instance, in CFamiTrackerDoc::GetSongSpeed() and CFamiTrackerDoc::GetTrackTitle(), Song and Track are used interchangeably.

nstbayless avatar Mar 19 '23 22:03 nstbayless

pedantically, 0CC 03.15.3+ is correct, but historically, the song-name interchanging has been present all the way back since FT 0.4.6

Gumball2415 avatar Mar 20 '23 04:03 Gumball2415

Ah, I hadn't realized that 0CC had changed this versus Famitracker. Still, it might be a good idea to fix the song/module name problem. It's often a point of confusion to new users that Famitracker modules can even have multiple songs at all.

nstbayless avatar Mar 20 '23 04:03 nstbayless