Avalonia.RangeSlider icon indicating copy to clipboard operation
Avalonia.RangeSlider copied to clipboard

Fail to include style

Open moonmoondog opened this issue 2 years ago • 8 comments

Following the Readme file, I failed the first step to add < rangeSlider:RangeSliderStyle /> into the <Application.Styles> </Application.Styles> . That is not recognized as a valid style axaml style file. Tried to put < StyleInclude Source="rangeSlider:RangeSliderStyle" />, but that failed to complie as well. What is the work around?

moonmoondog avatar Jul 22 '23 08:07 moonmoondog

What version of AvaloniaUI are you using?

DmitryNizhebovsky avatar Jul 22 '23 09:07 DmitryNizhebovsky

What version of AvaloniaUI are you using?

11.0.0

moonmoondog avatar Jul 22 '23 09:07 moonmoondog

What version of AvaloniaUI are you using?

11.0.0

sorry, but this control is not yet adapted to this version. I will try to add fixes soon

DmitryNizhebovsky avatar Jul 22 '23 09:07 DmitryNizhebovsky

What version of AvaloniaUI are you using?

11.0.0

sorry, but this control is not yet adapted to this version. I will try to add fixes soon

Much appreciated!

moonmoondog avatar Jul 22 '23 09:07 moonmoondog

Some links that may be useful: OnionWare's updates for an Avalonia 11 preview:

  • https://github.com/DmitryNizhebovsky/Avalonia.RangeSlider/pull/11

Some additional changes I made for the released Avalonia 11

  • https://github.com/onionware-github/Avalonia.RangeSlider/pull/1

Or just the code changes without the tab/space conversions in https://github.com/DmitryNizhebovsky/Avalonia.RangeSlider/pull/11

  • https://github.com/marklam/Avalonia.RangeSlider/commit/b199dda7b21065a44fbdb699d6b87236096b2c7b

I think there's been some changes to the recommended way to do styling in Avalonia 11 with ControlThemes but I'm not too familiar with all that so I didn't attempt to change anything there.

marklam avatar Jul 24 '23 11:07 marklam

Hi, thanks for the work you've done. But I've also found some other problems, like with Flyouts, and would like to fix them first. I'm a bit delayed by my main job, but I'll try to update the code for Avalonia 11 compatibility within a week

DmitryNizhebovsky avatar Jul 24 '23 13:07 DmitryNizhebovsky

Hi, thanks for the work you've done.

You're welcome, it's a very useful control and not one that I'd try to write myself. (I also don't want to take credit for the first batch of fixes that @onionware-github did).

But I've also found some other problems, like with Flyouts

If it's the problem where the flyouts swallowed the mouse down for the slider, I tried changing from flyout to tooltip here / here but I wasn't sure if that was the right workaround.

I'm a bit delayed by my main job

Of course! Thanks for taking the time to look at updating it.

marklam avatar Jul 24 '23 13:07 marklam

I've merged the edits to support AvaloniaUI 11.0.0

I've disabled Flyouts for the moment, but I'll try to fix the problem with them.

DmitryNizhebovsky avatar Jul 25 '23 21:07 DmitryNizhebovsky