djangogirls
djangogirls copied to clipboard
Add BleachField to contact form and model
Addresses #767.
Hey, @marksweb. Am not sure that's how django-bleach is supposed to work, just strip links and submit the form. So have converted this to a draft so I can get your input. Thanks
Codecov Report
Merging #793 (b62135b) into main (27b5ae5) will increase coverage by
0.06%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 78.67% 78.74% +0.06%
==========================================
Files 85 85
Lines 2612 2620 +8
Branches 251 251
==========================================
+ Hits 2055 2063 +8
Misses 499 499
Partials 58 58
Impacted Files | Coverage Δ | |
---|---|---|
contact/forms.py | 96.15% <100.00%> (+0.32%) |
:arrow_up: |
contact/models.py | 91.17% <100.00%> (+0.26%) |
:arrow_up: |
djangogirls/settings.py | 83.00% <100.00%> (+0.89%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 27b5ae5...b62135b. Read the comment docs.
Do we still want to bleach the message field? I believe it is only missing adding that unit test check, right?
@ramonsaraiva yeah I think it's still a worthwhile addition.
@marksweb I added changes to the comments you've made here https://github.com/DjangoGirls/djangogirls/pull/834 - closing this draft.