Actions Workflow cleanups.

[carltongibson]

f72addf00609a4955c107e43a2888569ae1d1cf4 adjusted the actions workflow, leaving a couple of TODOs commented out.

• [ ] Notifications
• [x] Dependency Caching
• [x] Notifying codecov.

Each one can be uncommented in a fresh PR, and seeing if it passes straight-off, or what adjustments are needed. (I commented the codecov one initially trying to get the workflow to run; it may just work. GHA complained about the other two, so I imagine something needs to be done there.)

Reference: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions

[marksweb]

Ok, been trying to sort codecov, but having an issue with the database not being accessible to the tests.

https://github.com/marksweb/djangogirls/runs/3355839128?check_suite_focus=true

Not yet figured out why. I've fiddled the project settings a little so that the database can be more configurable and doesn't assume localhost etc.

[amakarudze]

@marksweb ok, thanks. We can still use the Actions built-in one coverage. We just need to know our code coverage.

[marksweb]

@amakarudze Actually my action is running today, where it wasn't last night (using the same setup). I think there was some caching going on last night, because it was running (and failing) very quickly compared to what I've just seen.

There's a little more config to do in order to generate the coverage files to upload, but it's nearly there now 👍

[amakarudze]

That's good to hear @marksweb! Thank you for all your help.

[marksweb]

I'm not sure what the slack action does, but I think it could/should have limits put on where it runs.

I don't think it's restricted at all so I'm getting failure notifications every time I push to a branch.

[amakarudze]

@marksweb the Slack action should only send notifications to the #notifications channel on Slack saying whether a build was successful or not. At least that's what we are trying to do.

[marksweb]

@amakarudze So just pushes to the main branch would be ok? Or pull requests also?

[amakarudze]

@marksweb Pushes to main branches and pull requests as well.

[marksweb]

@amakarudze Thanks for confirming - I've put the necessary restrictions on it; https://github.com/DjangoGirls/djangogirls/pull/645

[amakarudze]

@marksweb maybe we can remove Slack notifications for now so that builds don't fail?