Yush G

Results 110 comments of Yush G

> We should ensure that the extension team wishes to accept this change before we include it here. Just wanted to give you a heads up before you do more...

> Got a simple PoC working for this, will come back to it later: [patcon/[email protected]](https://github.com/patcon/matterbridge/compare/805d84e...526-reactions) > > Currently just appends emoji to end of existing messages, but should really: >...

Yup, CI is great! All the tests should read from the same configuration file or something that has the inputs and outputs, so the different languages are all verified to...

> So, we need following? > > 1. GitHub Actions workflows which would check PR (based on files changed in perspective) against three test sets which are included for each...

> I see no good way to actually provide a single source for automated reading test vectors while autotest. It will degrade development experience significantly: introduction of file reading during...

Sweet, that sounds great. A circom test can use circom-tester library to do witness generation at least within tests, which is fast; proofgen will work 99% of the time if...

Feel free to make the needed PRs to the needed geometryresearch repos and they can be merged.

@weikengchen thanks for the thoughtful analysis! I'm worried that only having a single map to curve might break security. This is because the final step of the hash to curve...

Piotr: this method was deprecated and replaced by wallet_request It should be a pretty easy change, thanks for the catch!