DistroAV
DistroAV copied to clipboard
DistroAV
RPM support and lib64 dir fix
Hi!
First pull provide Spec for RPM-build, related with this https://github.com/Palakis/obs-ndi/issues/137 The working rpm packages available our official repositories
Second patch fix the /usr/lib vs /usr/lib64 problem on 64 bit systems like Fedora/blackPanther/etc
Regards
Closes #137
I suggest to aim for a spec that can be included to RPMFusion; a non-free for libndi and one for obs-ndi as free. Especially, as currently it is not required to have obs-studio installed?
Requires: %{_lib}ndi3 >= 3.8.0
Especially relevant as the (un)official description on the OBS Project website also references the installation of OBS with
sudo dnf install https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$(rpm -E %fedora).noarch.rpm https://download1.rpmfusion.org/nonfree/fedora/rpmfusion-nonfree-release-$(rpm -E %fedora).noarch.rpm
We don't understand well what do you want but we have fixed the spec file.
This sample works well on blackPanther OS but we didn't test it on Fedora, please test it:
https://github.com/blackPantherOS/obs-ndi/blob/master/obs-ndi.spec
It also requires avahi-daemon to allow source announcement and disccovery via mDNS to work.
Note: will check this later during the weekend.
I was able to get an RPM built for Fedora but it ended up being a good amount of work from where it is now. I managed to update everything to 4.8.0 as well and it loads. I haven't tested it against actual hardware yet.
This spec obvious needs some cleanup, especially as a number of things are hard-coded that shouldn't be, but it at least builds on Fedora 32.
https://oc.scottawilliams.com/nextcloud/index.php/s/4G99TkPcoz3qdMa
@vwbusguy I noticed you didn't add to the changelog what is changed... can you create a new PR with the improvements, as the OP didn;t reply for almost a year
This branch has conflicts that must be resolved
(Good to see you you here, Gerard)
Yeah, what I posted here was just how far I got to get it to compile. It is definitely going to need some clean up before it's PR worthy, but I'll see if I can do this soon.
Also, the conflict is with cmakelists.txt. It's been refactored since the original PR, but it's just two lines that need updated.
The people I was working with to build this for ended up needing NDIHDX drivers, so I don't actually have hardware to test this on. I can see that everything loads as expected in OBS on Fedora 32. If you want, i can clean it up and submit a PR, but I won't be able to test that it actually works besides OBS loading the module successfully. The biggest change is that I used obs-studio-devel instead of requiring the OBS source directly.
FYI, the obs-ndi, libndi and ndi-sdk packages are under review within RPM Fusion Theses will land in the default distribution for Fedora 32 and later once reviewed.
@blackPantherOS et all. I have watched this PR and even commented a long time ago on 2023/02/28, but I knew that this plugin was or should be and now is based on https://github.com/obsproject/obs-plugintemplate and I wanted them to fix the problem.
At a minimum, my recent updates to obs-ndi's plugintemplate code makes the change to CMakeLists.txt unnecessary.
They already have that change in https://github.com/obsproject/obs-plugintemplate/blob/c9ba8eeb7c90ecaafe33c7ac6c970f6d4ac6fe82/cmake/linux/helpers.cmake#L30
Also, just today they pushed a PR that fixed installing the .deb on Ubuntu and that I confirmed works.
If you really want RPM support, are you able to create a generic PR of the obs-ndi.spec (again, made generic for other plugins) changes for the https://github.com/obsproject/obs-plugintemplate project?
If no, then I could give it a try, but it is low priority for me until after I get 4.12.0 released.
If they reject the PR then I could be willing to apply this patch to obs-ndi only. If they accept the PR then I would obviously merge that change into obs-ndi.