Updating Tally Behavior : Nothing or Preview and/or Program + Per Source settings

[Trouffman]

Following some discussion in #687 and #1083 this issue is to address a broader need / discussion for managing Tally Lights.

As of 4.14: if settings to send tally is enable in general Plugin settings to Tally True

This will result int he following behavior:

• Whatever the source used in Preview or Program they will show Tally on.
• If a source is in preview then pushed to program > this will have both Preview & program tally flagged. (even if really just in Program)

This can be seen in the log with : 23:36:00.708: [DistroAV] 'NDI 3' ndi_source_thread: tally changed; Sending tally on_preview=1, on_program=1 In that example : Tally must be only in progam.

As of 4.14 : Tally feedback is enabled either for Preview Or Program, no matter the source. There are some case or source that you might not want to send the tally for (or be more selective) > For example an OBS acting as NDI Feed recorder, still want to see some of the source in Program tally but not in preview (preview would be managed otherwise)

Should a source be sent Program & preview ? : I believe not. (might be wrong)

New suggestion for behavior:

Step 1 : Tally can only be 1 thing at a time:

• OFF
• Preview
• Program

Program here should be understood as in "active", "shown" and used either in the Program pane, Stream, or any displays.

this is discussed and supposedly being fixed via : #1083 & #687.

Step 2 (improvement) : Allow each source to have their own tally settings as:

• Follow default settings (plugin settings) - default option when creating a source
• Tally update Disabled - override
• Tally update only while in preview - override
• Tally update only while in program - override
• Full Tally status (OFF/Preview/Program) - override

The general settings in the NDI output settings to be renamed as: "Tally - Send Source status to Tally (default behavior)" Program/Display [] Preview []

Argument for the change in Step 2:

• More granularity
• Migration of old settings simplified (they are still used and applies by default)

Argument against changes in step 2:

• add complexity / might be confusing for new users (could be hidden in the "advanced" section of a source settings.
• more code to maintain

This is a suggestion, open for discussion in this issue.