yellowbrick icon indicating copy to clipboard operation
yellowbrick copied to clipboard

Published 20 hours ago • verified publisher icon DistrictDataLabs

Improvements to the Manifold Visualizer

Open bbengfort opened this issue 7 years ago • 9 comments

The following improvements can be made to the manifold visualizer:

Note to contributors: items in the below checklist don't need to be completed in a single PR; if you see one that catches your eye, feel to pick it off the list!

  • [ ] describe the number of features the embedding represents (e.g. the number of columns in X) and optionally the number of points in the dataset
  • [ ] create a documentation example for clustering
  • [x] add frameon=True to legend
  • [ ] create documentation example using the standard scalar
  • [ ] get the visual tests to work on windows/decrease tolerance
  • [ ] decrease tolerance of test_manifold_pandas (not sure why the tolerance is so high)
  • [x] investigate the n_neighbors attribute; see below.

See #398 #399

bbengfort avatar May 18 '18 01:05 bbengfort

Hi! I wanted to work on the frameon feature? Is that still up for grabs?

jimmyshah avatar Apr 09 '19 19:04 jimmyshah

hi @jimmyshah Thanks for your interest in contributing to yellowbrick. however we rarely assign issues. But, You are more that welcome to open a PR for this addition. I look forward to seeing your contribution.

lwgray avatar Apr 09 '19 19:04 lwgray

@lwgray Thank you for the quick response! Sounds good to me, I'm excited to contribute!

jimmyshah avatar Apr 09 '19 20:04 jimmyshah

Hello again! I was interested in working on the n_neighbors attribute issue, is that one still available?

jimmyshah avatar Apr 14 '19 22:04 jimmyshah

hi @jimmyshah Let me again Thank you for your last contribution to yellowbrick. In regard to your currest ask, we rarely assign issues. But, You are more that welcome to open a PR for this addition. I look forward to seeing your next contribution.

lwgray avatar Apr 14 '19 23:04 lwgray

Hey there @jimmyshah and welcome back! The maintainers don't generally assign issues to contributors (we're only 5-6 people so that would be a bit too much management overhead for us), so the best strategy is to check if there's already an open PR addressing the issue (which in this case, there isn't... yet! 😉) Look forward to seeing your next PR!

rebeccabilbro avatar Apr 14 '19 23:04 rebeccabilbro

Thank you for the assistance @rebeccabilbro and @lwgray, I'm happy to contribute! I'll make a PR request shortly, after I've had a chance to make some code changes 🙂

jimmyshah avatar Apr 15 '19 00:04 jimmyshah

@naresh-bachwani -- please see this issue as you work on #930; @rebeccabilbro pointed out in #927 that we might be able to close this as you work through it.

bbengfort avatar Jul 22 '19 22:07 bbengfort

@naresh-bachwani have we managed to make progress on this? Can we close the issue?

bbengfort avatar Aug 29 '19 00:08 bbengfort