PythonMonkey icon indicating copy to clipboard operation
PythonMonkey copied to clipboard

Unstable xhr test

Open philippedistributive opened this issue 10 months ago • 1 comments

Issue type

Bug

How did you install PythonMonkey?

None

OS platform and distribution

No response

Python version (python --version)

No response

PythonMonkey version (pip show pythonmonkey)

No response

Bug Description

Philippe Laporte 12:41 PM @Tom Tang the test xhr.simple seems still a bit unstable: https://github.com/Distributive-Network/PythonMonkey/actions/runs/8650033361/job/23717654955?pr=311

Tom Tang 12:55 PM Could we change it to fetch from localhost or somewhere within the CI's private network, to make sure that it is not because of network issues?

Philippe Laporte 1:32 PM Maybe the test can spawn its own little server on localhost? We do that all the time on Android

Standalone code to reproduce the issue

No response

Relevant log output or backtrace

No response

Additional info if applicable

No response

What branch of PythonMonkey were you developing on? (If applicable)

No response

philippedistributive avatar Apr 11 '24 18:04 philippedistributive

Also https://github.com/Distributive-Network/PythonMonkey/actions/runs/8651360378/job/23721908409?pr=311

philippedistributive avatar Apr 11 '24 18:04 philippedistributive

This may actually due to a bug in our implementation for XMLHTTPRequest and/or the event-loop. The problem hasn't been seen for a while, especially since https://github.com/Distributive-Network/PythonMonkey/pull/354 and https://github.com/Distributive-Network/PythonMonkey/pull/156 are merged.

Xmader avatar Jun 12 '24 11:06 Xmader

one more failure

https://github.com/Distributive-Network/PythonMonkey/actions/runs/9844002769/job/27176473911

let's fix it now as 1.0 should be a super-clean release

philippedistributive avatar Jul 08 '24 18:07 philippedistributive

starting a node http server is impractical. We'll just have to live with this one

philippedistributive avatar Jul 16 '24 19:07 philippedistributive