PythonMonkey
PythonMonkey copied to clipboard
Unstable xhr test
Issue type
Bug
How did you install PythonMonkey?
None
OS platform and distribution
No response
Python version (python --version
)
No response
PythonMonkey version (pip show pythonmonkey
)
No response
Bug Description
Philippe Laporte 12:41 PM @Tom Tang the test xhr.simple seems still a bit unstable: https://github.com/Distributive-Network/PythonMonkey/actions/runs/8650033361/job/23717654955?pr=311
Tom Tang 12:55 PM Could we change it to fetch from localhost or somewhere within the CI's private network, to make sure that it is not because of network issues?
Philippe Laporte 1:32 PM Maybe the test can spawn its own little server on localhost? We do that all the time on Android
Standalone code to reproduce the issue
No response
Relevant log output or backtrace
No response
Additional info if applicable
No response
What branch of PythonMonkey were you developing on? (If applicable)
No response
Also https://github.com/Distributive-Network/PythonMonkey/actions/runs/8651360378/job/23721908409?pr=311
This may actually due to a bug in our implementation for XMLHTTPRequest
and/or the event-loop.
The problem hasn't been seen for a while, especially since https://github.com/Distributive-Network/PythonMonkey/pull/354 and https://github.com/Distributive-Network/PythonMonkey/pull/156 are merged.
one more failure
https://github.com/Distributive-Network/PythonMonkey/actions/runs/9844002769/job/27176473911
let's fix it now as 1.0 should be a super-clean release
starting a node http server is impractical. We'll just have to live with this one