Sovryn-frontend icon indicating copy to clipboard operation
Sovryn-frontend copied to clipboard

feat(chart): add graphql for trading chart

Open creed-victor opened this issue 2 years ago • 10 comments

https://sovryn.monday.com/boards/2218344956/views/53321005/pulses/2600564038

creed-victor avatar May 09 '22 13:05 creed-victor

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c907efd
Status: ✅  Deploy successful!
Preview URL: https://b5cd7723.sovryn.pages.dev
Branch Preview URL: https://feat-graph-charts.sovryn.pages.dev

View logs

cloudflare-pages[bot] avatar May 09 '22 14:05 cloudflare-pages[bot]

Added fixes. Best to test on staging because there is no enough data on testnet

creed-victor avatar Jun 03 '22 14:06 creed-victor

Deploy Preview for legacy-dapp ready!

Name Link
Latest commit 95a634f6cf9b845368f6caf1b6b58c127f0db203
Latest deploy log https://app.netlify.com/sites/legacy-dapp/deploys/6332ea2cbc86af00091f54ff
Deploy Preview https://deploy-preview-2193--legacy-dapp.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 23 '22 06:06 netlify[bot]

@creed-victor both testnet/mainnet environment fail to load charts locally, and same on deployed link above or on staging build here: https://feat-graph-charts--legacy-dapp.netlify.app/spot

soulBit avatar Aug 19 '22 19:08 soulBit

@creed-victor both testnet/mainnet environment fail to load charts locally, and same on deployed link above or on staging build here: https://feat-graph-charts--legacy-dapp.netlify.app/spot

Where did you find this link? Only this PR only built testnet FE. Testnet should work now, subgraph was protected by CORS

creed-victor avatar Aug 22 '22 07:08 creed-victor

@creed-victor using deployed netlify link (or running locally on testnet) on Spot page:

  • chart data for RBTC/XUSD pair does not load prior to 22nd August (30m candles) - switching timeframes causes more data to load, but stops at differing points for each timeframe. BPRO/DOC pair also has similar issue, so I assume it's a global thing.
  • USDT/DOC chart does not load at all

soulBit avatar Aug 25 '22 10:08 soulBit

@creed-victor using deployed netlify link (or running locally on testnet) on Spot page:

  • chart data for RBTC/XUSD pair does not load prior to 22nd August (30m candles) - switching timeframes causes more data to load, but stops at differing points for each timeframe. BPRO/DOC pair also has similar issue, so I assume it's a global thing.
  • USDT/DOC chart does not load at all

Candles not showing up because there is no data in the subgraph prior 22nd of August. Will ping Remy to check on the database.

creed-victor avatar Aug 30 '22 11:08 creed-victor

Ok, so checked code again and it works as intended. Issue with missing graphs is that there is no trades in some periods and trading view stops requesting for older chunk of data if previous one didn't return data to prevent unnecessary requests. As XUSD token was changed on testnet and there was not a lot of trades graph is not able to show candles correctly for dates before 22nd of August. I think testing should be done on staging subgraph instead

creed-victor avatar Aug 31 '22 10:08 creed-victor

Ok, so checked code again and it works as intended. Issue with missing graphs is that there is no trades in some periods and trading view stops requesting for older chunk of data if previous one didn't return data to prevent unnecessary requests. As XUSD token was changed on testnet and there was not a lot of trades graph is not able to show candles correctly for dates before 22nd of August. I think testing should be done on staging subgraph instead

I tried to test it on staging (locally) but I didn't see any chart on Spot page. It's probably related to the following errors, pls take a look at it @creed-victor . image

tiltom avatar Sep 01 '22 09:09 tiltom

I tried to test it on staging (locally) but I didn't see any chart on Spot page. It's probably related to the following errors, pls take a look at it @creed-victor . @tiltom, backend on staging / mainnet is not up to date so this is expected

creed-victor avatar Sep 02 '22 11:09 creed-victor