shiviz icon indicating copy to clipboard operation
shiviz copied to clipboard

URL-specified example logs that skip to visualization

Open bestchai opened this issue 4 years ago • 0 comments

Implement specific URLs for the example logs, so when used the user can skip directly to the visualization without going through the home page or input page.

[Issue created by albertxing: 2015-08-28]

[Comment created by bestchai: 2015-08-28] This is strange, but I'm getting non-deterministic results. Both, for albertxing deployment as well as the deployment on bestchai. Re-opening the page multiple times in different browsers eventually brings up a case where the visualization does not appear. Perhaps a non-deterministic race condition of some sort?

[Comment created by bestchai: 2015-08-28] Redeploying fixed it. Not sure what happened there.

Thanks!

[Comment created by albertxing: 2015-08-28] Hmm, that seemed to work: http://albertxing.bitbucket.org/shiviz/#facebook-study Do you want to try deploying again?

[Comment created by albertxing: 2015-08-28] I see. It still works locally for me at 34bd2d, but the new code is not showing up in the minified version.

I'll try to deploy it to my repo and see if I can reproduce the issue

[Comment created by bestchai: 2015-08-28] You're seeing revision 34bd2d8d3598 because I didn't push my merges into default. I just pushed; you should see them now. I redeployed from latest in default, which is 34bd. Are you sure you're not seeing the new bits?

[Comment created by albertxing: 2015-08-28] I checked the source in the deployed version and it didn't contain the new bits that I added. Also, it says revision 34bd2d8d3598 in the top corner, I'm not sure why.

[Comment created by bestchai: 2015-08-28] I deployed but it's not working for me. This include your latest commit (revision cda581cafab9) in the Issue154 branch.

i.e., trying http://bestchai.bitbucket.org/shiviz/#facebook-study only shows the front page

[Comment created by albertxing: 2015-08-28] Okay, this is fixed in cda581c You can specify a hash after the URL with the filename of the log, for example:

  • simple-reliable-broadcast
  • facebook-study
  • voldemort-simple-threadnames

These can be found in the data-log attributes for the example link elements (see index.html:299) They are attached to the URL like so:

http://bestchai.bitbucket.org/shiviz/#facebook-study

@bestchai The changes are in branch Issue154, let me know if it is good to merge.

bestchai avatar May 26 '20 07:05 bestchai