disnake icon indicating copy to clipboard operation
disnake copied to clipboard

ext.tasks.loop inheritance support

Open Enegg opened this issue 2 years ago • 3 comments

Summary

Supercedes and closes #259

Fixes an issue with Loop descriptor returning Loop instance in child classes; loop decorator supports Loop subclasses

Checklist

  • [ ] If code changes were made, then they have been tested
    • [ ] I have updated the documentation to reflect the changes
    • [x] I have formatted the code properly by running task lint
    • [ ] I have type-checked the code by running task pyright
  • [x] This PR fixes an issue
  • [x] This PR adds something new (e.g. new method or parameters)
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

Enegg avatar Jul 25 '22 16:07 Enegg

This errors on import time.

onerandomusername avatar Jul 26 '22 18:07 onerandomusername

@Enegg will you be resolving the issues with this pr?

onerandomusername avatar Aug 16 '22 18:08 onerandomusername

Uh-oh, cannot make the .start and .restart use the ParamSpec without previously ressolving the stripping self param problem.

Enegg avatar Sep 20 '22 21:09 Enegg

Uh-oh, cannot make the .start and .restart use the ParamSpec without previously ressolving the stripping self param problem.

@shiftinv will you be fixing this?

onerandomusername avatar Sep 26 '22 04:09 onerandomusername