disnake icon indicating copy to clipboard operation
disnake copied to clipboard

Support new thread and message attributes (position, message_count, total_message_sent)

Open onerandomusername opened this issue 2 years ago • 2 comments

Summary

https://github.com/discord/discord-api-docs/pull/5206

What is the feature request for?

The core library

The Feature

Message.position, should probably default to None outside of forum channels, or we could think about using -1 so its always an integer. Thread.message_count Thread.total_message_sent

However, there is a small implementation detail here: Should we increment the message_count and total_message_sent variables when we receive a message_create event for the thread? I believe we should.

In addition, when we receive a message_delete event in a thread, we should decrement message_count if the thread is cached whether or not the message is cached.

onerandomusername avatar Jul 18 '22 22:07 onerandomusername

I shall take a look at this.

rmblau avatar Jul 22 '22 16:07 rmblau

Assigned you.

onerandomusername avatar Jul 22 '22 16:07 onerandomusername

@rmblau are you still interested in implementing this feature?

onerandomusername avatar Aug 14 '22 07:08 onerandomusername

Yes I am, I just got back from family vacation and can take a look at it this week.

rmblau avatar Aug 14 '22 07:08 rmblau

Because there's no progress on this, I'm moving it back to up for grabs.

onerandomusername avatar Sep 02 '22 03:09 onerandomusername

I shall take a look at this.

Snipy7374 avatar Sep 02 '22 21:09 Snipy7374