disnake icon indicating copy to clipboard operation
disnake copied to clipboard

docs: refactor examples

Open onerandomusername opened this issue 3 years ago • 1 comments

Summary

Checklist

  • [ ] If code changes were made, then they have been tested
    • [ ] I have updated the documentation to reflect the changes
    • [ ] I have formatted the code properly by running task lint
    • [ ] I have type-checked the code by running task pyright
  • [ ] This PR fixes an issue
  • [ ] This PR adds something new (e.g. new method or parameters)
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

onerandomusername avatar Jun 11 '22 06:06 onerandomusername

Related PR: #557

onerandomusername avatar Jul 01 '22 15:07 onerandomusername

While more changes could be made to the examples, this is a good start, and I think its worth being added at this condition rather than the ideally finished one--this is still better than what we had.

onerandomusername avatar Aug 16 '22 18:08 onerandomusername

~~Loading the env is done in __init__.py if the dotenv module is installed~~

No idea what this comment was initially about, I think I confused it for #247

To run with dotenv, we can actually use dotenv run python example_name.py on the command line which will load all of the environment variables before running the process.

onerandomusername avatar Aug 16 '22 18:08 onerandomusername

~Loading the env is done in __init__.py if the dotenv module is installed~

No idea what this comment was initially about, I think I confused it for #247

To run with dotenv, we can actually use dotenv run python example_name.py on the command line which will load all of the environment variables before running the process.

Ah. In that case, LGTM. Apologies for the late response, GitHub notifications are failing me.

spifory avatar Aug 23 '22 12:08 spifory

not newsworthy on its own, at least not right now

onerandomusername avatar Aug 23 '22 23:08 onerandomusername