fix: type annotation for `View.add_item` method
Summary
Fixes type annotation issue in View.add_item method where type checkers (Pylance/mypy) reported "Type of 'add_item' is partially unknown" due to missing generic parameter in Item annotation.
Checklist
- [x] If code changes were made, then they have been tested
- [x] I have updated the documentation to reflect the changes
- [x] I have formatted the code properly by running
uv run nox -s lint - [x] I have type-checked the code by running
uv run nox -s pyright
- [x] This PR fixes an issue
- [ ] This PR adds something new (e.g. new method or parameters)
- [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
- [ ] This PR is not a code change (e.g. documentation, README, ...)
Documentation build overview
📚 disnake | 🛠️ Build #30212142 | 📁 Comparing 9dd5a8feb3f7a840f26cca20465c5cb3f88c512b against latest (0b119051760bb8a36f6ca8e2193fa294a5c02525)
Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
Does this actually work for doing
view = View()
view.add_item(ui.Button())
?
The components are currently typed to default to None on creation unless explicitly parametrized (ui.Button[View](...))
Does this actually work for doing
view = View() view.add_item(ui.Button())? The components are currently typed to default to
Noneon creation unless explicitly parametrized (ui.Button[View](...))
This doesn't work, and pylance gives me an error because the generic type of Item in the add_item method is unknown. If I specify Self or None, there will be no error
pylance gives me an error because the generic type of Item in the add_item method is unknown.
I was asking specifically if this works after your fix, but it's clear now it is not as pyright in CI is failing.
Item[Self] likely needs to become Item[Any].