disnake icon indicating copy to clipboard operation
disnake copied to clipboard

refactor: use absolute imports

Open onerandomusername opened this issue 2 months ago • 6 comments

Summary

feeler for whether absolute imports is worth it

onerandomusername avatar Oct 20 '25 06:10 onerandomusername

Documentation build overview

📚 disnake | 🛠️ Build #30032265 | 📁 Comparing 344f67d9e596189a348ce339443712c0b2b73a0f against latest (7c3b4f031493606ae0919b9555f8289760d9bdab)


🔍 Preview build

Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

(also, for reference: https://github.com/DisnakeDev/disnake/pull/951)

shiftinv avatar Oct 20 '25 07:10 shiftinv

+1 from me, in any case

Sharp-Eyes avatar Oct 20 '25 09:10 Sharp-Eyes

(also, for reference: https://github.com/DisnakeDev/disnake/pull/951)

In disnake.ext.*, imports from the main lib and ext previously were visually separated (by virtue of using absolute imports for the former); the new order is confusing

disnake.ext can be configured as forced separate, or we can configure custom import groups and order

Enegg avatar Oct 20 '25 14:10 Enegg

(also, for reference: #951)

In disnake.ext.*, imports from the main lib and ext previously were visually separated (by virtue of using absolute imports for the former); the new order is confusing

disnake.ext can be configured as forced separate, or we can configure custom import groups and order

Already did that :smile:

onerandomusername avatar Oct 20 '25 16:10 onerandomusername

Fyi, there's also a python.analysis.importFormat pylance setting that controls how pylance auto-imports stuff, but it is set to "absolute" by default

Enegg avatar Oct 20 '25 16:10 Enegg