disnake icon indicating copy to clipboard operation
disnake copied to clipboard

feat(emoji)!: implement app emojis

Open Snipy7374 opened this issue 1 year ago • 2 comments

Summary

  • Closes GH-1223

Checklist

  • [ ] If code changes were made, then they have been tested
    • [x] I have updated the documentation to reflect the changes
    • [x] I have formatted the code properly by running pdm lint
    • [x] I have type-checked the code by running pdm pyright
  • [ ] This PR fixes an issue
  • [x] This PR adds something new (e.g. new method or parameters)
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

Snipy7374 avatar Aug 10 '24 22:08 Snipy7374

I marked this ready for review even though i still don't know if we should provide the ability to cache app emojis at startup, as you can see i did put a boolean argument but didn't implement any logic for it so far.

Snipy7374 avatar Aug 21 '24 09:08 Snipy7374

I'm strongly in favor of splitting the models into a GuildEmoji and AppEmoji. The current approach is pretty much saying "an Emoji can have both .guild_id and .application_id, one of, or neither!"

Anyhow, minor nitpicks below.

If we want to split them into different classes (I had this talk with @shiftinv in the past, but at the time they said it was fine to go with this approach) we would most likely split them into Emoji and AppEmoji to minimize breaking changes

Snipy7374 avatar Apr 14 '25 21:04 Snipy7374

I'm strongly in favor of splitting the models into a GuildEmoji and AppEmoji. The current approach is pretty much saying "an Emoji can have both .guild_id and .application_id, one of, or neither!" Anyhow, minor nitpicks below.

If we want to split them into different classes (I had this talk with @shiftinv in the past, but at the time they said it was fine to go with this approach) we would most likely split them into Emoji and AppEmoji to minimize breaking changes

@shiftinv did your opinion change on this?

Snipy7374 avatar Aug 22 '25 09:08 Snipy7374

Documentation build overview

📚 disnake | 🛠️ Build #29602396 | 📁 Comparing ffb7bde2c17c0c3b39cd1229fe26e824b40f1d61 against latest (dca108c373e9f1277dbdf223457d3bddde79b791)


🔍 Preview build

Show files changed (49 files in total): 📝 49 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified