disnake icon indicating copy to clipboard operation
disnake copied to clipboard

Published 20 hours ago • verified publisher icon DisnakeDev

refactor(tooling): Switch to ruff-format for formatting.

Open elenakrittik opened this issue 11 months ago • 5 comments

Summary

Replaces black with ruff-format.

~~Depends on #1168~~

Checklist

  • [x] If code changes were made, then they have been tested
    • [x] I have updated the documentation to reflect the changes
    • [x] I have formatted the code properly by running pdm lint
    • [x] I have type-checked the code by running pdm pyright
  • [ ] This PR fixes an issue
  • [ ] This PR adds something new (e.g. new method or parameters)
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [x] This PR is not a code change (e.g. documentation, README, ...)

elenakrittik avatar Mar 19 '24 15:03 elenakrittik

Ready for consideration!

elenakrittik avatar May 14 '24 13:05 elenakrittik

I think I voiced my concerns about all-in-one tooling on discord before; to summarize, not being able to update linter and formatter separately anymore isn't ideal.

Don't see much of an issue with that, but given that

I'd prefer only merging this after the next release

We'll have a chance to test it 😄

elenakrittik avatar May 19 '24 14:05 elenakrittik

https://github.com/DisnakeDev/disnake/pull/1169/commits/165ab8484b816187a54fda57b1492503299d38ab Undo the formatting changes too

Excuse me, why?

elenakrittik avatar May 19 '24 17:05 elenakrittik

Excuse me, why?

What's the point of fmt: off if the thing it was guarding from being formatted, has been formatted? https://github.com/DisnakeDev/disnake/pull/1169/files#diff-6377fad5f75948c1eaa880c932839dd3f47b01c21056433ada31632cb518a665R480-R499

Enegg avatar May 19 '24 17:05 Enegg

Ruff v0.5 has just been released, so technically this can move forward. I'll try and find some time to update this

elenakrittik avatar Jun 28 '24 10:06 elenakrittik