FrostedGlass icon indicating copy to clipboard operation
FrostedGlass copied to clipboard

Various differences in blur, shading, or tinting

Open Kuuuube opened this issue 2 years ago • 8 comments

Describe the bug

The most recent updates have made some things look much brighter without any changes to my settings.

To Reproduce

The way I compared back to the old version of the theme was throwing the old theme from your deploy branch into my custom css while using an invalid import url in the theme settings file. To go back to the new version I removed the custom css and fixed the import url in the theme settings file.

If it helps here is my settings file (renamed to txt for upload): FrostedGlass.theme.css.txt

Screenshots

Here's a few examples of what it looks like before and after the recent updates:

Before: message_old

After: message_new

Before: user_old

After: user_new

Before: right_click_old

After: right_click_new

Infomation (please complete the following information)

Discord channel: Stable
OS: Windows
Mod: BetterDiscord
Discord language: English

Kuuuube avatar Sep 27 '22 14:09 Kuuuube

I've also noticed that the variable --popout-modal-brightness doesn't seem to change anything that I can see while other settings such as the --popout-modal-blur does, and besides the popups mentioned above, the one you get when you right click a forum post (to say, easily follow a post or add tags) or the search suggestions is, at least with my current background, too bright, making text difficult to read, and I could not find a way to change how this appears. image image

davidc1701 avatar Sep 27 '22 16:09 davidc1701

I've also noticed that the variable --popout-modal-brightness doesn't seem to change anything that I can see, and besides the popups mentioned above, the one you get when you right click a forum post (to say, easily follow a post or add tags) is, at least with my current background, too bright and I could not find a way to change how this appears.

To add to this I also noticed that in the deploy branch those variables were changed but these ones don't work either https://github.com/DiscordStyles/FrostedGlass/blob/114fcf9f5bfe9849e7b1bfc18a73a6bc0cfacb3c/FrostedGlass.theme.css#L28-L31 https://github.com/DiscordStyles/FrostedGlass/blob/114fcf9f5bfe9849e7b1bfc18a73a6bc0cfacb3c/FrostedGlass.theme.css#L52

Kuuuube avatar Sep 27 '22 16:09 Kuuuube

I must've set something up incorrectly as it should just work. I'll take a look later today.

I've also sperated the user popout and general modal/popout variables because so many people were complaining.

Gibbu avatar Sep 27 '22 23:09 Gibbu

To further add to this, the variables for tint (--tint-colour and --tint-brightness) are currently having no effect. owFbRNW 1 Diq7lEo 1 Hope this helps!

AzureShark avatar Sep 28 '22 23:09 AzureShark

@Kuuuube Can you share your .theme.css file?

Gibbu avatar Sep 28 '22 23:09 Gibbu

It should've been fixed.

GitHub I didn't say close it!

Gibbu avatar Sep 28 '22 23:09 Gibbu

Can confirm that tinting and pop-out variables appear to be fixed!

AzureShark avatar Sep 28 '22 23:09 AzureShark

It should've been fixed.

Everything seems to be fixed now as far as i can tell except the popout when clicking on someone's name. Both on the right sidebar or above a message.

I also notice when switching back and forth between the versions there is a tiny change in alignment of the background image.

Here's the settings for comparison

FrostedGlass.theme.css.txt Latest version

FrostedGlass.theme.css.txt Old version from commit ff98112

The second one has the old version of FrostedGrass.css stuffed inside it instead of importing so it's easier to switch back and forth.

Kuuuube avatar Sep 29 '22 02:09 Kuuuube

hey popout-modal-brightness is still not doing anything for me

MentalMasochist avatar Nov 03 '22 18:11 MentalMasochist

Repalce --popout-modal-brightness with overlay-brightness

Gibbu avatar Nov 03 '22 22:11 Gibbu

Closing as this appears to be completely fixed. I can't find any areas where it's broken anymore.

Kuuuube avatar Nov 22 '22 15:11 Kuuuube