disciple-tools-theme icon indicating copy to clipboard operation
disciple-tools-theme copied to clipboard

Help Text for Comments

Open brady-lamansky-gtt opened this issue 1 year ago • 4 comments

This PR is dependent on my previous Workflow action: Comment Tokens PR, so it should be merged afterwards if everything looks good. https://github.com/DiscipleTools/disciple-tools-theme/pull/2541

brady-lamansky-gtt avatar Aug 15 '24 21:08 brady-lamansky-gtt

@brady-lamansky-gtt thanks for the PR! For context on new PRs, would you be able to also attach a screenshot (or multiple) of the changes?

corsacca avatar Aug 16 '24 09:08 corsacca

@brady-lamansky-gtt, Sorry, i mean screenshots of the changed UI or functionality. Like i did here: https://github.com/DiscipleTools/disciple-tools-theme/pull/2541#issuecomment-2293168296 The code changes are easily accessible in the files changes tab.

corsacca avatar Aug 16 '24 13:08 corsacca

@corsacca ah I see, that makes sense haha.

brady-lamansky-gtt avatar Aug 16 '24 14:08 brady-lamansky-gtt

When you reach step 3 of creating a workflow, you will see a button for Help Text. Screenshot 2024-08-16 at 9 05 17 AM

After clicking it, a tab on the right side of the page will be visible that shows all fields that can be referenced through comment tokens (either user select fields or connection fields). It displays the field name & how to reference it. Screenshot 2024-08-16 at 9 05 31 AM

brady-lamansky-gtt avatar Aug 16 '24 14:08 brady-lamansky-gtt

@cairocoder01 Two things I'm unsure if I did efficiently:

  1. I replaced the hidden helptext button with the working one on line 1629-1633 of dt-utilities-workflows.js
  2. I changed the list of fields within the table to be a height of 300px with overflow so that it's scrollable. With the right_column being sticky, many fields went off screen and couldn't be seen. Unsure if 300px is the optimal height

brady-lamansky-gtt avatar Aug 22 '24 16:08 brady-lamansky-gtt

This looks good. @corsacca This is ready from my perspective.

cairocoder01 avatar Sep 11 '24 10:09 cairocoder01

Brilliant. Nice work @brady-lamansky-gtt!

corsacca avatar Sep 17 '24 10:09 corsacca