dioxus icon indicating copy to clipboard operation
dioxus copied to clipboard

Documenation for Guides -> Router -> Example Project has cut off lines

Open ineiti opened this issue 1 year ago • 3 comments

Problem

When looking at the documentation, the Guides -> Router -> Example Project has many cut off lines.

Steps To Reproduce

Steps to reproduce the behavior:

  • Go to https://dioxuslabs.com/learn/0.6/router/example/
  • Look at the first paragraph:

Overview In this guide, you'll learn to effectively use Dioxus Router whether you're

To follow along with the router example, you'll need a working Dioxus app.Dioxus book to get started.

Expected behavior

Find the complete phrase. There and in many other places in the same Example Projects

Questionnaire I'm interested in fixing this myself but don't know where to start

I clicked on Edit this page, but the link is not valid. Also, I couldn't find the text in the github repo, nor in the main repo...

ineiti avatar Dec 19 '24 17:12 ineiti

The source for the router index page is here: https://github.com/DioxusLabs/docsite/blob/main/docs-src/0.6/src/router/index.md

Another example for cut off lines: https://dioxuslabs.com/learn/0.6/router/example/building-a-nest source here: https://github.com/DioxusLabs/docsite/blob/main/docs-src/0.6/src/router/example/building-a-nest.md

The lines aren't cut off in the sources.

ousado avatar Jan 01 '25 20:01 ousado

I think the files must be auto-generated, because the cut-off text is also missing in the .rs files themselves:

https://github.com/DioxusLabs/docsite/blob/main/src/docs/router_06.rs#L9054

But the only reference I find in the README is with regard to tailwindcss, and as far as I understand, the files in docs-src are not built by tailwindcss.

Any help from @ealmloff or @jkelleyrtp on how the files in docs-src get built?

ineiti avatar Jan 05 '25 20:01 ineiti

This is being treated here: DioxusLabs/docsite#369

ineiti avatar Jan 06 '25 20:01 ineiti

Should be fixed!

jkelleyrtp avatar Jan 08 '25 22:01 jkelleyrtp

https://github.com/DioxusLabs/docsite/pull/365 updates the version of include_mdbook to build with the fixed version. The live docsite will be fixed after that PR is merged

ealmloff avatar Jan 08 '25 23:01 ealmloff

Closing as this seems fixed.

DogeDark avatar Feb 28 '25 23:02 DogeDark