dioxus icon indicating copy to clipboard operation
dioxus copied to clipboard

Fix hot reloading components with keys

Open ealmloff opened this issue 1 year ago • 5 comments

We were adding keys from component to the component literal pool which caused indexing issues because keys don't show up as props

Fixes #2881

ealmloff avatar Aug 26 '24 13:08 ealmloff

Hmm, I cherry picked these onto my local and it did not fix #2881

rogusdev avatar Aug 26 '24 15:08 rogusdev

Hmm, I cherry picked these onto my local and it did not fix #2881

I reverted a bit too much while fixing tests. Should be fixed now

ealmloff avatar Aug 26 '24 16:08 ealmloff

Ha, now it's inverted: falsetrue

rogusdev avatar Aug 26 '24 16:08 rogusdev

Should be fixed now: Screenshot 2024-08-26 at 11 49 46 AM

ealmloff avatar Aug 26 '24 16:08 ealmloff

Yeah, works for me, thanks! (Including in my actual project)

rogusdev avatar Aug 26 '24 17:08 rogusdev