dionaea icon indicating copy to clipboard operation
dionaea copied to clipboard

python/ftp - Hotfix FTPDataConnect.__init__ requiring defaults for args

Open PaulosV opened this issue 3 years ago • 2 comments

ISSUE TYPE
  • Bugfix
SUMMARY

Fixes #324. Adds dummy defaults to the FTPDataConnect constructor, as required by PR #318 (commit acc8bc87723181459081e525126368f30edecd81)

I was thinking about adding further sanity checks for the values, but then I checked the fix in the PR and it seems adequate to leave it like it is now.

PaulosV avatar Jul 14 '22 11:07 PaulosV

Welcome to the community and thanks for opening your first pull request. Feel free to look for more issues to tackle at https://github.com/DinoTools/dionaea/issues

welcome[bot] avatar Jul 14 '22 11:07 welcome[bot]

Thanks for your contribution. I will have a look at it.

phibos avatar Jul 29 '22 12:07 phibos