Dionaea doesn't react correctly to HUP signal

[xambroz]

ISSUE TYPE

• Bug Report
• Feature Idea
• Documentation Report

DIONAEA VERSION

release 0.7.0

CONFIGURATION

defalt configuration, file logging

OS / ENVIRONMENT

• Fedora 28

SUMMARY

Whole function src/signals.c/sighup_cb() is commented out: https://github.com/DinoTools/dionaea/blob/master/src/signals.c

Dionaea is not correctly reacting to the logrotate sending HUP signal as it is described in the documentation: https://github.com/DinoTools/dionaea/blob/master/doc/source/old/configuration.rst

STEPS TO REPRODUCE

• Start dionaea
• run logrotate logrotate --force /etc/logrotate.d/dionaea

EXPECTED RESULTS

One would expect the logs to be rotated. Current dionaea.log and dionaea-errors.log moved to something like dionaea.log-20180601 dionaea-errors.log-20180601 , possibly configuration reloaded, and start writing to the new dionaea.log and dionaea-errors.log.

ACTUAL RESULTS

Files get rotated, but the file handle is kept open, means that new dionaea.log is created in the filesystem by logrotate, but dionaea keeps writing to the just-moved file dionaea.log-20180601.

[phibos]

Thanks for reporting the issue. I think fixing the issue in 0.9.0 or 0.10.0 might by a good idea.

The documentation you have mentioned is part of the old documentation. After fixing the bug the documentation should also be updated.