dionaea icon indicating copy to clipboard operation
dionaea copied to clipboard

Fix typo in the table emu_services

Open mcantoni opened this issue 8 years ago • 6 comments

ISSUE TYPE
  • Bugfix
SUMMARY

This fixes the bug described in https://github.com/DinoTools/dionaea/issues/139

mcantoni avatar Dec 29 '17 10:12 mcantoni

Can one of the admins verify this patch?

dino-bot avatar Dec 29 '17 10:12 dino-bot

There should be some kind of migration path

phibos avatar Mar 10 '18 21:03 phibos

There is one more script needing to fix - modules/python/util/logsql2postgres.py

$ grep -R emu_serivce * modules/python/util/logsql2postgres.py: emu_serivce, modules/python/dionaea/logsql.py: """SELECT emu_serivce FROM emu_services LIMIT 1""") modules/python/dionaea/logsql.py: emu_serivce INTEGER PRIMARY KEY, modules/python/dionaea/logsql.py: emu_serivce, connection, emu_service_url

xambroz avatar Mar 22 '18 17:03 xambroz

You are right. What do you think about a new release without the old references?

mcantoni avatar Apr 06 '18 14:04 mcantoni

I have reviewed the patch again and I'm unsure if fixing a typo is more important than keep compatibility with external tools.

What do you think?

phibos avatar Jun 17 '18 20:06 phibos

I agree, we wait. For the moment we close the request. Thank you

mcantoni avatar Jun 29 '18 07:06 mcantoni