telegram_media_downloader icon indicating copy to clipboard operation
telegram_media_downloader copied to clipboard

Support for multiple chat downloads and autorefresh

Open Hugeldugelking opened this issue 2 years ago • 6 comments

The script is now able to download media from multiple chats and scan the chats again after a given interval. For this, the config.yaml needed some modifications. Tests were also updated for the modified downloader script.

fixes: #77

Hugeldugelking avatar May 20 '22 13:05 Hugeldugelking

@Hugeldugelking please check the Pylint errors. More details can be found here

Dineshkarthik avatar May 20 '22 14:05 Dineshkarthik

@Dineshkarthik I don't get no pylint errors anymore. Sorry, it's my first time working on an open project with such tools :)

Hugeldugelking avatar May 20 '22 15:05 Hugeldugelking

Codecov Report

Merging #235 (e7f3ed9) into master (92fb58a) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   98.93%   99.06%   +0.13%     
==========================================
  Files           6        6              
  Lines         187      213      +26     
==========================================
+ Hits          185      211      +26     
  Misses          2        2              
Impacted Files Coverage Δ
media_downloader.py 98.64% <100.00%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92fb58a...e7f3ed9. Read the comment docs.

codecov[bot] avatar May 20 '22 16:05 codecov[bot]

@Hugeldugelking is the auto_refresh optional or mandatory? I don't want to make this application something like long-pooling/continuous running one, it should be a stateful (last read message ids) single run and the users can add it to cron if they want to run this on regular intervals.

Dineshkarthik avatar May 24 '22 09:05 Dineshkarthik

@Dineshkarthik auto_refresh is optional. If set to 0 the script will only run once. I did this because I want to try to put this script in a docker container to run it on an unraid server for example. Your Idea with cron is great and I will take a look at it. Should auto_refresh remain optional in the application? Otherwise I'd remove this from the code. Regarding the failing checks: This has nothing to do with my modification, does it?

Hugeldugelking avatar May 24 '22 11:05 Hugeldugelking

bump :3

ofifoto avatar Jun 10 '22 18:06 ofifoto